Skip to content

Consider changing sharedmain behaviour about panic'ing when a config map is missing #3195

New issue
New issue
Open
#3419
Open
Consider changing sharedmain behaviour about panic'ing when a config map is missing#3195
#3419
Labels
good first issueDenotes an issue ready for a new contributor, according to the "help wanted" guidelines.triage/acceptedIssues which should be fixed (post-triage)

Description

@dprotaso
dprotaso
opened on Jun 27, 2025

That's fine. I'm slighly worried about "halt and catch fire" as a behavior when a configmap we ship has been removed. The idea of shipping them has mostly been about documentation, not about requiring them to have specific contents (or even be present) for things to function.

Originally posted by @evankanderson in #3190 (comment)

Activity

  1. dprotaso
    added
    triage/acceptedIssues which should be fixed (post-triage)
    good first issueDenotes an issue ready for a new contributor, according to the "help wanted" guidelines.
    on Jun 27, 2025

  2. Caesarsage commented on Jul 21, 2025

    @Caesarsage
    Caesarsage
    on Jul 21, 2025

    hello @dprotaso

    i would love to contribute to this issue

  3. anjalii-28 commented on Jan 11, 2026

    @anjalii-28
    anjalii-28
    on Jan 11, 2026
    Contributor

    Hi @dprotaso , I’d like to take this issue up.

    My plan is to replace the panic on missing ConfigMap with a clearer error/log and graceful shutdown.
    Please let me know if you have a preferred behavior (fail fast vs continue with defaults).

  4. evankanderson commented on Jan 11, 2026

    @evankanderson
    evankanderson
    on Jan 11, 2026 via email
    Member

  5. dprotaso commented on Jan 12, 2026

    @dprotaso
    dprotaso
    on Jan 12, 2026
    MemberAuthor

    Would it be possible to behave as if the ConfigMap were empty, but to still
    watch for changes to the resource if it is created? That feels like the
    "correct" behavior.

    In general yes but for observability we need controller restarts.

  6. anjalii-28 commented on Jan 13, 2026

    @anjalii-28
    anjalii-28
    on Jan 13, 2026
    Contributor

    Thanks for the clarification!
    I’ll treat a missing ConfigMap as empty at startup while keeping the watcher active, without changing observability restart behavior.

  7. amarkdotdev commented on Nov 3, 2026

    @amarkdotdev
    amarkdotdev
    on Nov 3, 2026

    Addressed in #3419 along with #3417. /assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    good first issueDenotes an issue ready for a new contributor, according to the "help wanted" guidelines.triage/acceptedIssues which should be fixed (post-triage)

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions