You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In Kubernetes 1.13 a dry-run feature was added to allow validating an object without instantiating it.
Our architecture has a mutating webhook as well as a controller to reconcile events. Today our webhook validations are not great at catching problems with kubernetes shapes such as the corev1.Container shape. Any issues that get through our validation that fail kubernetes validations result in the controller unable to reconcile which is further along in the API call lifecycle and more difficult to debug.
This issue is to leverage the dry-run feature in our webhook to ensure kubernetes shapes we are passed are validated synchronously with the user's request. Since this will require Kubernetes 1.13 it is currently blocked on other reasons for us to move forward to requiring a higher version, but capturing this here for potential future Knative releases.
Issues go stale after 90 days of inactivity.
Mark the issue as fresh by adding the comment /remove-lifecycle stale.
Stale issues rot after an additional 30 days of inactivity and eventually close.
If this issue is safe to close now please do so by adding the comment /close.
Issues go stale after 90 days of inactivity.
Mark the issue as fresh by adding the comment /remove-lifecycle stale.
Stale issues rot after an additional 30 days of inactivity and eventually close.
If this issue is safe to close now please do so by adding the comment /close.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Activity
knative-housekeeping-robot commentedon Dec 21, 2019
Issues go stale after 90 days of inactivity.
Mark the issue as fresh by adding the comment
/remove-lifecycle stale.Stale issues rot after an additional 30 days of inactivity and eventually close.
If this issue is safe to close now please do so by adding the comment
/close.Send feedback to Knative Productivity Slack channel or file an issue in knative/test-infra.
/lifecycle stale
vagababov commentedon Dec 21, 2019
/remove-lifecycle stale
whaught commentedon Feb 14, 2020
/assign
knative-housekeeping-robot commentedon May 15, 2020
Issues go stale after 90 days of inactivity.
Mark the issue as fresh by adding the comment
/remove-lifecycle stale.Stale issues rot after an additional 30 days of inactivity and eventually close.
If this issue is safe to close now please do so by adding the comment
/close.Send feedback to Knative Productivity Slack channel or file an issue in knative/test-infra.
/lifecycle stale
vagababov commentedon May 15, 2020
/remove-lifecycle stale
vagababov commentedon Jun 3, 2020
Weston,
can we close this out, or you still do something in this space?
whaught commentedon Jun 3, 2020
/close
Sure. I have #8077 filed for the next step
knative-prow-robot commentedon Jun 3, 2020
@whaught: Closing this issue.
Details
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.