Skip to content

fix: RFC6265 compliant default cookie name#197

Merged
dead-horse merged 1 commit into
koajs:masterfrom
zautumnz:fix/default-cookie-name
Apr 28, 2020
Merged

fix: RFC6265 compliant default cookie name#197
dead-horse merged 1 commit into
koajs:masterfrom
zautumnz:fix/default-cookie-name

Conversation

@zautumnz

Copy link
Copy Markdown
Contributor

Closes #28

@zautumnz zautumnz changed the title fix: RFC6265 default cookie name fix: RFC6265 compliant default cookie name Apr 23, 2020
@coveralls

coveralls commented Apr 23, 2020

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 100.0% when pulling dd52632 on zacanger:fix/default-cookie-name into 23f7f52 on koajs:master.

@jonathanong jonathanong self-assigned this Apr 24, 2020
@dead-horse

Copy link
Copy Markdown
Member

we can't merge this right now because It can break compatibility, maybe you can add a note in README ?

@zautumnz

Copy link
Copy Markdown
Contributor Author

@dead-horse good point. Should that go in History.md instead as a major version note?

@jonathanong

Copy link
Copy Markdown
Member

@zacanger yep.

we can do a major bump - we shouldn't be afraid to do those

@jonathanong jonathanong assigned dead-horse and fengmk2 and unassigned jonathanong Apr 24, 2020
@zautumnz

zautumnz commented Apr 24, 2020

Copy link
Copy Markdown
Contributor Author

@jonathanong sounds good, changelog updated!

@dead-horse
dead-horse merged commit 7fca3de into koajs:master Apr 28, 2020
@zautumnz
zautumnz deleted the fix/default-cookie-name branch April 28, 2020 16:17
@dead-horse

Copy link
Copy Markdown
Member

6.0.0 released

@zautumnz

Copy link
Copy Markdown
Contributor Author

Sorry about the package-lock, I forgot Koa repos don't use that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Default cookie name doesn't satisfy RFC6265

6 participants