feat: Add Session.regenerate() method (#34) - #221
Merged
Conversation
And make both save() and regenerate() compatible with koa-passport
lehni
force-pushed
the
feature/regeneration
branch
from
December 5, 2022 16:23
13febdd to
1eb74a1
Compare
|
I would really like to see this added as well. I have tested the fork of @lehni and have run into no issues. I hope this can be merged soon. |
Contributor
Author
|
@fengmk2 I am sorry to nag, but is there any chance to consider this? the latest version of |
Member
|
I will merge this change after setup github action. |
fengmk2
changed the title
fengmk2
approved these changes
Feb 4, 2023
Member
|
6.4.0 |
This was referenced Feb 4, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And make both
save()andregenerate()compatible withkoa-passportv5.0.0This is based on #74 which is a bit outdated, and more work was needed to make this work with
koa-passportdue to the use ofcallbackarguments.See rkusa/koa-passport#181 for more details.