Skip to content

IDs ignored #37

Open
Open

Description

@joto

IDs < 0 and IDs not of type int64_t or uint64_t are simply ignored here:
https://github.com/mapbox/vector-tile/blob/2.x/include/mapbox/vector_tile/builder.hpp#L48-L59

Is this correct? If yes, I think it needs to be documented.

Activity

  1. flippmoke commented on Feb 2, 2018

    @flippmoke
    Member

    I think the core problem is more that we support int64_t and uint64_t id types in our internal geometry.hpp structure as well. We should probably look into only having one of these, but yes it should be documented.

  2. added this to the 2.0 milestone on Feb 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions