Skip to content

Changed if clause to catch all 2XX HTTP Codes - #130

Merged
TKIPisalegacycipher merged 1 commit into
meraki:masterfrom
deejaypro:master
Dec 17, 2020
Merged

Changed if clause to catch all 2XX HTTP Codes#130
TKIPisalegacycipher merged 1 commit into
meraki:masterfrom
deejaypro:master

Conversation

@deejaypro

Copy link
Copy Markdown

Fixed #129 with catching all 2xx status codes inside if clause.

@TKIPisalegacycipher

Copy link
Copy Markdown
Collaborator

Hi @deejaypro -- a straightforward change but what was the scenario that led you to this?

@deejaypro

Copy link
Copy Markdown
Author

Hey @TKIPisalegacycipher,
i was working with the createNetworkWebhooksWebhookTest endpoint and it was always throwing an exception.
createNetworkWebhooksWebhookTest returns a HTTP Code 201 Created which wasnt matching any condition in the if clause. This led to the exception raise in line 218.

@TKIPisalegacycipher
TKIPisalegacycipher merged commit f07c101 into meraki:master Dec 17, 2020
@TKIPisalegacycipher

Copy link
Copy Markdown
Collaborator

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Async HTTP calls throws exception with 2XX status code

2 participants