added option to handle logging scheme externally - #173
Merged
Conversation
| simulate=SIMULATE_API_CALLS, | ||
| be_geo_id=BE_GEO_ID, | ||
| caller=MERAKI_PYTHON_SDK_CALLER, | ||
| inherit_logging_config= INHERIT_LOGGING_CONFIG, |
Collaborator
There was a problem hiding this comment.
Unnecessary space, will remove.
| - log_file_prefix (string): log file name appended with date and timestamp | ||
| - print_console (boolean): print logging output to console? | ||
| - suppress_logging (boolean): disable all logging? you're on your own then! | ||
| - inherit_logging_config (boolean): Inherits you're own logging scheme |
Collaborator
There was a problem hiding this comment.
typo: should be your instead of you're. will fix
| be_geo_id=BE_GEO_ID, | ||
| caller=MERAKI_PYTHON_SDK_CALLER, | ||
| use_iterator_for_get_pages=False, | ||
| inherit_logging_config=INHERIT_LOGGING_CONFIG |
Collaborator
There was a problem hiding this comment.
This can be at the same order in the kwarg list in both init files. Will fix.
TKIPisalegacycipher
approved these changes
Feb 3, 2022
TKIPisalegacycipher
left a comment
TKIPisalegacycipher
left a comment
Collaborator
There was a problem hiding this comment.
Thank you for this contribution. Left some comments on fixing this up, which I'll handle.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some users might already use their own logging scheme defined as part of their workflow.
This way, we can consider and work with both cases. If the user has a logging scheme already setup, with their own handlers, formatters, etc, we just instantiate a logger and inherit the configs from the user's logging scheme.
If there's no inheritance, we use the current logic.