Changed References to package.path - pyinstaller support Issue #187 - #188
Merged
Conversation
…r support Changes: 1. Updated Meraki and Meraki_v0 to look back at package for reference instead of backing through folder structure. This will provide support for pyinstaller. Updated Example "apiData2CSV_v1.py" It was still looking for package meraki_v1 which has been renamed to meraki.
Contributor
Author
|
Also includes reference to broken example file containing reference to meraki_v1 |
CamoDunn
changed the title
TKIPisalegacycipher
requested changes
Apr 7, 2022
TKIPisalegacycipher
left a comment
TKIPisalegacycipher
left a comment
Collaborator
There was a problem hiding this comment.
Thank you for this PR. I added some notes -- looks like minor changes might be required.
Contributor
Author
|
@TKIPisalegacycipher this is my first collab, let me know if there is something I'm doing wrong as far as pushing or confirming changes were made. |
TKIPisalegacycipher
approved these changes
Jun 2, 2022
TKIPisalegacycipher
left a comment
TKIPisalegacycipher
left a comment
Collaborator
There was a problem hiding this comment.
Thank you for updating this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…r support
Changes: 1. Updated Meraki and Meraki_v0 to look back at package for reference instead of backing through folder structure.
This will provide support for pyinstaller.
Updated Example "apiData2CSV_v1.py" It was still looking for package meraki_v1 which has been renamed to meraki.
Ref Issue #187