ci: remove unreachable release/orchestration workflows from httpx - #408
Merged
Merged
Conversation
These workflows are only ever executed from the default branch (main):
- create-release.yml (workflow_run + dispatch; workflow_run always
uses main's copy, and dispatch automation passes
no --ref so it also runs main's)
- regenerate-library.yml (dispatch only; main's copy is the sole
orchestrator and checks out httpx via ref:)
- publish-release.yml (release + dispatch; release event uses main's copy)
- watch-openapi-release.yml (schedule + dispatch; schedule only fires on
the default branch)
Their httpx copies could never fire from automation and had drifted into
a stale, superseded architecture, making a manual dispatch actively
harmful. Single-source them on main. Branch-scoped workflows (test-pr,
test-library, test-library-generator, dependabot-auto-merge) are kept.
(httpx has no enable-early-access.yml.)
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
TKIPisalegacycipher
added a commit
that referenced
this pull request
Jul 8, 2026
PRs #407/#408 deleted this workflow from beta/httpx as unreachable orchestration, but it triggers on 'release: [created]', which runs the workflow file from the TAGGED COMMIT's tree, not the default branch. Every beta/dev release cut after 2026-06-10 created a GitHub Release but never published to PyPI. Restoring it here so releases from this branch publish again. create-release/watch/regenerate/enable-early-access stay single-sourced on main (workflow_run/schedule/dispatch triggers use main's copy). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
TKIPisalegacycipher
added a commit
that referenced
this pull request
Jul 8, 2026
PRs #407/#408 deleted this workflow from beta/httpx as unreachable orchestration, but it triggers on 'release: [created]', which runs the workflow file from the TAGGED COMMIT's tree, not the default branch. Every beta/dev release cut after 2026-06-10 created a GitHub Release but never published to PyPI. Restoring it here so releases from this branch publish again. create-release/watch/regenerate/enable-early-access stay single-sourced on main (workflow_run/schedule/dispatch triggers use main's copy). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes 4 workflows from httpx that can only ever execute from the default branch (
main), per GitHub's trigger semantics:create-release.ymlworkflow_run+workflow_dispatchworkflow_runalways uses the default-branch copy; dispatch automation passes no--ref, so it runs main's tooregenerate-library.ymlworkflow_dispatchref:and operates on itpublish-release.ymlrelease+workflow_dispatchreleaseevent uses the default-branch copywatch-openapi-release.ymlschedule+workflow_dispatchscheduleonly fires on the default branch(httpx has no
enable-early-access.yml.)Why now
Beyond being unreachable, these copies had drifted into a stale, superseded architecture. A manual UI dispatch against httpx would run obsolete logic — an active footgun. This supersedes the create-release sync (#406): single-sourcing on main is strictly better than keeping copies in lockstep.
Kept (branch-scoped — must exist per-branch)
test-pr.yml(push/PR),test-library.yml(workflow_call),test-library-generator.yml(push/PR),dependabot-auto-merge.yml(pull_request_target).Verified no remaining workflow on httpx references the deleted files.
🤖 Generated with Claude Code