fix: Point to database reference files - #1550
Merged
Tom Meschter (tmeschter) merged 7 commits intoApr 2, 2026
Merged
Conversation
Fixes microsoft#1536. In issue microsoft#1536 an integration test run has failed due to a timeout. Among other things, the agent needed eight tries to come up with a sufficiently complex password for the Azure SQL admin account... but it shouldn't have been specifying a password to begin with. Instead it should be using Entra-based authentication. The SQL database reference docs explain this, but the test never pulled them in. Here we add further links to these docs in a few key locations to help pull them in.
Tom Meschter (tmeschter)
requested review from
kvenkatrajan and
Wallace Breza (wbreza)
as code owners
March 27, 2026 22:48
Contributor
There was a problem hiding this comment.
Pull request overview
Updates azure-prepare reference documentation to more reliably pull in Azure SQL Database guidance (notably Entra-only auth) during App Service–based app planning, addressing the integration-test timeout root cause in #1536.
Changes:
- Add cross-links from App Service guidance to common database backend reference docs (SQL Database, Cosmos DB).
- Add an explicit “App Service + API + SQL Database” research pattern that points to the SQL Database reference set.
- Add reference links in the architecture service-mapping table and bump
azure-prepareskill version.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| plugin/skills/azure-prepare/references/services/app-service/README.md | Adds a “Common Data Backends” section linking to SQL Database and Cosmos DB references. |
| plugin/skills/azure-prepare/references/research.md | Adds a concrete research-loading sequence for App Service + API + SQL Database to encourage loading SQL auth docs. |
| plugin/skills/azure-prepare/references/architecture.md | Adds “Reference” links for key data services to make deeper guidance discoverable during architecture planning. |
| plugin/skills/azure-prepare/SKILL.md | Bumps skill version to reflect reference updates. |
kvenkatrajan
previously approved these changes
Mar 30, 2026
Remove references to the azure-security and azure-security-hardening skills as they do not exist.
Tom Meschter (tmeschter)
requested review from
JasonYeMSFT (JasonYeMSFT) and
Sai Koumudi Kaluvakolanu (saikoumudi)
as code owners
March 30, 2026 16:05
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Comments suppressed due to low confidence (2)
plugin/skills/azure-prepare/references/research.md:26
azure-networkingis listed as a related skill for AKS, but there is noazure-networkingskill inplugin/skills/. This should be updated to an existing AKS/networking skill (e.g.,azure-kubernetes) so the guidance is actionable.
| AKS | [AKS](services/aks/README.md) | `azure-networking` |
plugin/skills/azure-prepare/references/research.md:43
- The Key Vault row points to a non-existent
azure-keyvault-expiration-auditskill (no such directory underplugin/skills/). If the intent is Key Vault expiration auditing, consider pointing to the existingazure-complianceskill (which includes Key Vault expiration checks) or remove the skill reference.
| Key Vault | [Key Vault](services/key-vault/README.md) | `azure-keyvault-expiration-audit` |
kvenkatrajan
previously approved these changes
Mar 30, 2026
Tom Meschter (tmeschter)
changed the title
kvenkatrajan
previously approved these changes
Mar 31, 2026
Wallace Breza (wbreza)
previously approved these changes
Apr 1, 2026
Wallace Breza (wbreza)
left a comment
Wallace Breza (wbreza)
left a comment
Collaborator
There was a problem hiding this comment.
Looks good — all 9 database/service reference links verified, non-existent skill references correctly removed, version bumps and snapshots properly updated. Token-efficient at ~1,136 tokens added.
Tom Meschter (tmeschter)
dismissed stale reviews from Wallace Breza (wbreza) and kvenkatrajan
via
April 2, 2026 16:48
70e3d95
kvenkatrajan
approved these changes
Apr 2, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
plugin/skills/azure-prepare/references/research.md:44
azure-keyvault-expiration-auditis listed as a related skill for Key Vault, but there is no skill by that name inplugin/skills/. If the intent is to route to the Key Vault expiration audit, point to theazure-complianceskill (it contains the Key Vault expiration assessment) or rename this entry to match an actual invokable skill.
| **Security & Identity** | | |
| Key Vault | [Key Vault](services/key-vault/README.md) | `azure-keyvault-expiration-audit` |
| Managed Identity | — | `entra-app-registration` |
Tom Meschter (tmeschter)
added a commit
to tmeschter/GitHub-Copilot-for-Azure
that referenced
this pull request
Apr 2, 2026
* Point to database reference files Fixes microsoft#1536. Fixes microsoft#1541. In issue microsoft#1536 an integration test run has failed due to a timeout. Among other things, the agent needed eight tries to come up with a sufficiently complex password for the Azure SQL admin account... but it shouldn't have been specifying a password to begin with. Instead it should be using Entra-based authentication. The SQL database reference docs explain this, but the test never pulled them in. Here we add further links to these docs in a few key locations to help pull them in. * Remove references to non-existent skills Remove references to the azure-security and azure-security-hardening skills as they do not exist. * Bump versions * Update snapshots
Barbara 4bes (Ba4bes)
pushed a commit
to Ba4bes/GitHub-Copilot-for-Azure
that referenced
this pull request
Apr 24, 2026
* Point to database reference files Fixes microsoft#1536. Fixes microsoft#1541. In issue microsoft#1536 an integration test run has failed due to a timeout. Among other things, the agent needed eight tries to come up with a sufficiently complex password for the Azure SQL admin account... but it shouldn't have been specifying a password to begin with. Instead it should be using Entra-based authentication. The SQL database reference docs explain this, but the test never pulled them in. Here we add further links to these docs in a few key locations to help pull them in. * Remove references to non-existent skills Remove references to the azure-security and azure-security-hardening skills as they do not exist. * Bump versions * Update snapshots
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1536.
Fixes #1541.
In issue #1536 an integration test run has failed due to a timeout. Among other things, the agent needed eight tries to come up with a sufficiently complex password for the Azure SQL admin account... but it shouldn't have been specifying a password to begin with. Instead it should be using Entra-based authentication. The SQL database reference docs explain this, but the test never pulled them in. Here we add further links to these docs in a few key locations to help pull them in.
Similarly in #1541 some but not all of the files were read by the agent.