Use a test-specific followUp prompt for "does not deploy aspire custom resources" - #1682
Merged
Merged
Conversation
…m resources"
The default FOLLOW_UP_PROMPT ("Go with recommended options and proceed with
Azure deployment.") improperly encourages the agent to continue with a
deployment even when there is nothing to deploy. In this test the Aspire
app contains only non-deployable custom resources, and the agent correctly
identifies this, but then the follow-up prompt pushes it to add a new
project and deploy anyway.
Replace with a prompt that allows the agent to stop when it determines
there is no further work.
Fixes microsoft#1591
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts the azure-deploy integration test harness so the “does not deploy aspire custom resources” scenario is not pushed into an unintended deployment path when the agent correctly determines there is nothing deployable.
Changes:
- Replaces the default
FOLLOW_UP_PROMPTfor thedoes not deploy aspire custom resourcestest with a test-specific follow-up that permits stopping when there’s no further work.
kvenkatrajan
approved these changes
Apr 2, 2026
Barbara 4bes (Ba4bes)
pushed a commit
to Ba4bes/GitHub-Copilot-for-Azure
that referenced
this pull request
Apr 24, 2026
…m resources" (microsoft#1682) The default FOLLOW_UP_PROMPT ("Go with recommended options and proceed with Azure deployment.") improperly encourages the agent to continue with a deployment even when there is nothing to deploy. In this test the Aspire app contains only non-deployable custom resources, and the agent correctly identifies this, but then the follow-up prompt pushes it to add a new project and deploy anyway. Replace with a prompt that allows the agent to stop when it determines there is no further work. Fixes microsoft#1591 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default
FOLLOW_UP_PROMPT("Go with recommended options and proceed with Azure deployment.") improperly encourages the agent to continue with a deployment even when there is nothing to deploy. In thedoes not deploy aspire custom resourcestest, the Aspire app contains only non-deployable custom resources (TalkingClock,TestResourcewith.ExcludeFromManifest()). The agent correctly identifies this and creates a plan saying the app is not deployable, but then the follow-up prompt pushes it to add a new Web API project and deploy anyway—causing thecontainsDeployLinksassertion to fail.This PR replaces the follow-up prompt for this specific test with one that allows the agent to stop when it determines there is no further work.
Fixes #1591