Add missing instructions for terraform two-phase pre deploy check - #2138
Merged
JasonYeMSFT (JasonYeMSFT) merged 3 commits intoMay 2, 2026
Merged
Conversation
Co-authored-by: Copilot <copilot@github.com>
JasonYeMSFT (JasonYeMSFT)
requested review from
Jon Gallant (jongio),
kvenkatrajan,
Paul Yuknewicz (paulyuk),
Tom Meschter (tmeschter) and
Wallace Breza (wbreza)
as code owners
May 1, 2026 21:39
Contributor
There was a problem hiding this comment.
Pull request overview
Adds missing Terraform guidance to the azure-deploy pre-deploy checklist so the two-phase Container Apps + ACR deployment pattern (and RBAC propagation gate) is documented for both Bicep and Terraform paths.
Changes:
- Updates the Container Apps + ACR RBAC pre-deploy callout to include
terraform applyas a Phase 1 alternative. - Adds a “Two-phase Terraform pattern” explanation alongside the existing Bicep pattern.
Show a summary per file
| File | Description |
|---|---|
| plugin/skills/azure-deploy/references/pre-deploy-checklist.md | Expands the two-phase Container Apps + ACR RBAC health check guidance to cover Terraform provisioning and post-apply deployment steps. |
Copilot's findings
Comments suppressed due to low confidence (1)
plugin/skills/azure-deploy/references/pre-deploy-checklist.md:288
- The “Required flow for this scenario” steps currently only describe the
azd provision→ health check →azd deploypath. Since this section now documentsterraform apply(and a manual CLI deploy path), the flow should be expanded to cover those alternatives; otherwise the section contradicts itself for Terraform users.
**Required flow for this scenario:**
1. Run `azd provision`
2. Complete the RBAC health check in this section
3. Run `azd deploy`
- Files reviewed: 1/1 changed files
- Comments generated: 3
Jon Gallant (jongio)
left a comment
Jon Gallant (jongio)
left a comment
Collaborator
There was a problem hiding this comment.
The Terraform pattern description is technically clear. One gap: the "Required flow for this scenario" steps still only describe the azd path, so Terraform users don't get explicit step-by-step guidance despite the pattern block above.
Co-authored-by: Copilot <copilot@github.com>
Member
Author
kvenkatrajan
reviewed
May 1, 2026
Co-authored-by: Copilot <copilot@github.com>
kvenkatrajan
approved these changes
May 1, 2026
This was referenced May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add instructions to fill the gap of missing those for terraform two-phase container app pre deploy check.
Checklist
cd tests && npm test)npm run test:skills:integration -- <skill>)USE FOR/DO NOT USE FOR/PREFER OVERclauses: confirmed no routing regressions for competing skillsRelated Issues
resolves: #2134