azure-upgrade: add Redis (ACR/OSS and ACRE) -> AMR migration scenarios - #2159
Conversation
There was a problem hiding this comment.
Pull request overview
This PR extends the azure-upgrade skill to cover Azure Cache for Redis migrations to Azure Managed Redis (AMR) by adding Redis-related trigger wording, adding two Redis upgrade-scenario rows, and introducing a dedicated reference doc that disambiguates ACR/OSS vs ACRE and routes users to the appropriate externally maintained migration skill.
Changes:
- Updated
azure-upgradeskill description and trigger/scenario tables to include Redis → AMR migration scenarios. - Added a new Redis reference doc (
redis-to-amr.md) that explains how to distinguish ACR vs ACRE and links to the correct dedicated migration skill repo. - Updated trigger keyword snapshots to reflect the new skill content/keywords.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
plugin/skills/azure-upgrade/SKILL.md |
Adds Redis → AMR scenarios and updates skill description/triggers/references. |
plugin/skills/azure-upgrade/references/services/redis/redis-to-amr.md |
New disambiguation + routing doc pointing to the correct dedicated migration skill based on source SKU/type. |
tests/azure-upgrade/__snapshots__/triggers.test.ts.snap |
Snapshot updates for the skill’s extracted keywords after Redis content changes. |
f182996 to
b03b5a9
Compare
Jon Gallant (jongio)
left a comment
There was a problem hiding this comment.
Clean routing design - the reference doc correctly delegates to dedicated skills rather than inlining migration logic that would drift.
Integration tests are well-structured with smart termination logic (capping tool calls, checking both navigation and skill name surfacing). The negative routing assertion on non-Redis prompts is a good defensive addition.
One thing to be aware of: the description reformulation dropped the plural \SDKs\ keyword from the trigger extraction (visible in the snapshot diff where \sdks\ disappears). The Java SDK migration prompts still match on other keywords (java, legacy, microsoft, migrate, modernize), so routing should be unaffected in practice - but worth confirming if you haven't already run the full trigger test suite against Java prompts.
Jon Gallant (jongio)
left a comment
There was a problem hiding this comment.
Clean routing design - the reference doc correctly delegates to dedicated skills rather than inlining migration logic that would drift.
Integration tests are well-structured with smart termination logic (capping tool calls, checking both navigation and skill name surfacing). The negative routing assertion on non-Redis prompts is a good defensive addition.
One thing to be aware of: the description reformulation dropped the plural \SDKs\ keyword from the trigger extraction (visible in the snapshot diff where \sdks\ disappears). The Java SDK migration prompts still match on other keywords (java, legacy, microsoft, migrate, modernize), so routing should be unaffected in practice - but worth confirming if you haven't already run the full trigger test suite against Java prompts.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
b03b5a9 to
1d59cfc
Compare
36a90f7
into
microsoft:main
|
Azure Cache for Redis team relies on their eval/ manual tests and don't expect the skill to change much. The official retirement date for ACR/AMR is 09-30-2028 and don't currently have plans to expand their testing infra on GitHub repo. |
Description
Adds a single 'Redis to AMR' reference doc that routes users to the correct dedicated skill based on source SKU:
ACR/OSS (Basic/Standard/Premium) -> https://github.com/AzureManagedRedis/amr-migration-skill
ACRE (Enterprise/EnterpriseFlash) -> https://github.com/AzureManagedRedis/acre-to-amr-migration-skill
Both migrations target Azure Managed Redis but use different ARM resource types and migration mechanics, so disambiguation guidance is included.
Checklist
cd tests && npm test)npm run test:skills:integration -- <skill>)USE FOR/DO NOT USE FOR/PREFER OVERclauses: confirmed no routing regressions for competing skillsRelated Issues
Fixes #2156