Skip to content

azure-upgrade: add Redis (ACR/OSS and ACRE) -> AMR migration scenarios - #2159

Merged
Lorenzo Lodi Rizzini (lolodi) merged 1 commit into
microsoft:mainfrom
lolodi:lolodi/amr-migration-pointer
May 5, 2026
Merged

azure-upgrade: add Redis (ACR/OSS and ACRE) -> AMR migration scenarios#2159
Lorenzo Lodi Rizzini (lolodi) merged 1 commit into
microsoft:mainfrom
lolodi:lolodi/amr-migration-pointer

Conversation

@lolodi

Copy link
Copy Markdown
Collaborator

Description

Adds a single 'Redis to AMR' reference doc that routes users to the correct dedicated skill based on source SKU:

ACR/OSS (Basic/Standard/Premium) -> https://github.com/AzureManagedRedis/amr-migration-skill

ACRE (Enterprise/EnterpriseFlash) -> https://github.com/AzureManagedRedis/acre-to-amr-migration-skill

Both migrations target Azure Managed Redis but use different ARM resource types and migration mechanics, so disambiguation guidance is included.

Checklist

  • Tests pass locally (cd tests && npm test)
  • If modifying skill descriptions: verified routing correctness with integration tests (npm run test:skills:integration -- <skill>)
  • If modifying skill USE FOR / DO NOT USE FOR / PREFER OVER clauses: confirmed no routing regressions for competing skills

Related Issues

Fixes #2156

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends the azure-upgrade skill to cover Azure Cache for Redis migrations to Azure Managed Redis (AMR) by adding Redis-related trigger wording, adding two Redis upgrade-scenario rows, and introducing a dedicated reference doc that disambiguates ACR/OSS vs ACRE and routes users to the appropriate externally maintained migration skill.

Changes:

  • Updated azure-upgrade skill description and trigger/scenario tables to include Redis → AMR migration scenarios.
  • Added a new Redis reference doc (redis-to-amr.md) that explains how to distinguish ACR vs ACRE and links to the correct dedicated migration skill repo.
  • Updated trigger keyword snapshots to reflect the new skill content/keywords.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

File Description
plugin/skills/azure-upgrade/SKILL.md Adds Redis → AMR scenarios and updates skill description/triggers/references.
plugin/skills/azure-upgrade/references/services/redis/redis-to-amr.md New disambiguation + routing doc pointing to the correct dedicated migration skill based on source SKU/type.
tests/azure-upgrade/__snapshots__/triggers.test.ts.snap Snapshot updates for the skill’s extracted keywords after Redis content changes.

Comment thread plugin/skills/azure-upgrade/SKILL.md Outdated
Comment thread plugin/skills/azure-upgrade/SKILL.md Outdated
Comment thread plugin/skills/azure-upgrade/references/services/redis/redis-to-amr.md Outdated
Comment thread plugin/skills/azure-upgrade/references/services/redis/redis-to-amr.md Outdated
Comment thread tests/azure-upgrade/__snapshots__/triggers.test.ts.snap Outdated
@lolodi
Lorenzo Lodi Rizzini (lolodi) force-pushed the lolodi/amr-migration-pointer branch 3 times, most recently from f182996 to b03b5a9 Compare May 4, 2026 23:21

@jongio Jon Gallant (jongio) left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean routing design - the reference doc correctly delegates to dedicated skills rather than inlining migration logic that would drift.

Integration tests are well-structured with smart termination logic (capping tool calls, checking both navigation and skill name surfacing). The negative routing assertion on non-Redis prompts is a good defensive addition.

One thing to be aware of: the description reformulation dropped the plural \SDKs\ keyword from the trigger extraction (visible in the snapshot diff where \sdks\ disappears). The Java SDK migration prompts still match on other keywords (java, legacy, microsoft, migrate, modernize), so routing should be unaffected in practice - but worth confirming if you haven't already run the full trigger test suite against Java prompts.

@jongio Jon Gallant (jongio) left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean routing design - the reference doc correctly delegates to dedicated skills rather than inlining migration logic that would drift.

Integration tests are well-structured with smart termination logic (capping tool calls, checking both navigation and skill name surfacing). The negative routing assertion on non-Redis prompts is a good defensive addition.

One thing to be aware of: the description reformulation dropped the plural \SDKs\ keyword from the trigger extraction (visible in the snapshot diff where \sdks\ disappears). The Java SDK migration prompts still match on other keywords (java, legacy, microsoft, migrate, modernize), so routing should be unaffected in practice - but worth confirming if you haven't already run the full trigger test suite against Java prompts.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Comment thread tests/azure-upgrade/integration.test.ts
Comment thread plugin/skills/azure-upgrade/SKILL.md
@lolodi
Lorenzo Lodi Rizzini (lolodi) merged commit 36a90f7 into microsoft:main May 5, 2026
12 checks passed
@saikoumudi

Copy link
Copy Markdown
Contributor

Azure Cache for Redis team relies on their eval/ manual tests and don't expect the skill to change much. The official retirement date for ACR/AMR is 09-30-2028 and don't currently have plans to expand their testing infra on GitHub repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: Add Azure Cache for Redis (ACR/OSS and ACRE) -> Azure Managed Redis (AMR) scenarios to azure-upgrade skill

4 participants