Skip to content

fix: link azure-compute reference guides so vally reachability passes - #2744

Closed
Paul Yuknewicz (paulyuk) wants to merge 1 commit into
mainfrom
fix/azure-compute-orphan-refs
Closed

fix: link azure-compute reference guides so vally reachability passes#2744
Paul Yuknewicz (paulyuk) wants to merge 1 commit into
mainfrom
fix/azure-compute-orphan-refs

Conversation

@paulyuk

@paulyuk Paul Yuknewicz (paulyuk) commented Jul 4, 2026

Copy link
Copy Markdown
Member

Problem

The eval job (vally-cli --strict) fails on every open PR with:

✗ orphan-files: Found 4 orphan file(s) not reachable from SKILL.md:
  references/retail-prices-api.md, references/vm-families.md,
  references/vm-quotas.md, references/vmss-guide.md

These four files are used — but only via ../../references/… links from workflows/vm-recommender/vm-recommender.md. vally's reachability walk does not follow those upward relative links, so it treats them as orphans. This is a pre-existing failure on main, unrelated to any feature PR, but it shows a red eval check on all of them.

Fix

Add a Reference Guides list to azure-compute/SKILL.md linking the four files directly (references/…), making them reachable in one hop.

Verification

npx @microsoft/vally-cli@^0.5.0 lint plugin/skills/ --eval-spec evals/ --strict …
→ ✅ azure-compute (3/3 checks passed); full run exit 0

No behavior change — documentation reachability only.

@paulyuk
fix: link azure-compute reference guides so vally reachability passes
7a5932b 
The four references/ files (vm-families, vmss-guide, vm-quotas,
retail-prices-api) were only reachable via ../../references/ links from
workflows/vm-recommender.md. vally's --strict orphan-files check does not
follow those upward relative links, so it flagged them as orphans and
failed the eval job on every open PR. Add a Reference Guides list to
SKILL.md so they are directly reachable.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings July 4, 2026 21:42
@github-actions

github-actions Bot commented Jul 4, 2026

Copy link
Copy Markdown
Contributor
Details# 🔍 Token Analysis Report

@github-copilot-for-azure/scripts@1.0.0 tokens
node --import tsx src/tokens/cli.ts compare --base origin/main --head HEAD --markdown

📊 Token Change Report

Comparing origin/main → HEAD

Summary

Metric Value
📈 Total Change +108 tokens (+13%)
Before 821 tokens
After 929 tokens
Files Changed 1

Changed Files

File Before After Change
plugin/skills/azure-compute/SKILL.md 821 929 +108 (+13%)

@github-copilot-for-azure/scripts@1.0.0 tokens
node --import tsx src/tokens/cli.ts check --markdown

📊 Token Limit Check Report

Checked: 731 files
Exceeded: 105 files

⚠️ Files Exceeding Token Limits

File Tokens Limit Over By
.github/skills/analyze-skill-issues/SKILL.md 2109 500 +1609
.github/skills/analyze-test-run/SKILL.md 2471 500 +1971
.github/skills/file-test-bug/SKILL.md 628 500 +128
.github/skills/sensei/README.md 3531 2000 +1531
.github/skills/sensei/SKILL.md 3026 500 +2526
.github/skills/sensei/references/EXAMPLES.md 3701 2000 +1701
.github/skills/sensei/references/LOOP.md 4169 2000 +2169
.github/skills/sensei/references/SCORING.md 4299 2000 +2299
.github/skills/skill-authoring/SKILL.md 839 500 +339
.github/skills/vally-eval/SKILL.md 1764 500 +1264
plugin/skills/airunway-aks-setup/SKILL.md 1025 500 +525
plugin/skills/appinsights-instrumentation/SKILL.md 937 500 +437
plugin/skills/azure-ai/SKILL.md 820 500 +320
plugin/skills/azure-aigateway/SKILL.md 1261 500 +761
plugin/skills/azure-aigateway/references/policies.md 2342 2000 +342
plugin/skills/azure-cloud-migrate/SKILL.md 1085 500 +585
plugin/skills/azure-cloud-migrate/references/services/container-apps/cloudrun-deployment-guide.md 2029 2000 +29
plugin/skills/azure-cloud-migrate/references/services/container-apps/deployment-guide.md 2458 2000 +458
plugin/skills/azure-cloud-migrate/references/services/container-apps/fargate-deployment-guide.md 2587 2000 +587
plugin/skills/azure-cloud-migrate/references/services/container-apps/spring-deployment-guide.md 3871 2000 +1871
plugin/skills/azure-cloud-migrate/references/services/functions/lambda-to-functions.md 2600 2000 +600
plugin/skills/azure-cloud-migrate/references/services/functions/runtimes/javascript.md 2181 2000 +181
plugin/skills/azure-compliance/SKILL.md 1188 500 +688
plugin/skills/azure-compute/SKILL.md 929 500 +429
plugin/skills/azure-compute/workflows/essential-machine-management/references/emm-enable-flow.md 2344 2000 +344
plugin/skills/azure-compute/workflows/vm-troubleshooter/vm-troubleshooter.md 2509 2000 +509
plugin/skills/azure-deploy/SKILL.md 1645 500 +1145
plugin/skills/azure-deploy/references/pre-deploy-checklist.md 4692 2000 +2692
plugin/skills/azure-deploy/references/recipes/azd/errors.md 4004 2000 +2004
plugin/skills/azure-deploy/references/troubleshooting.md 2038 2000 +38
plugin/skills/azure-diagnostics/SKILL.md 1423 500 +923
plugin/skills/azure-enterprise-infra-planner/SKILL.md 911 500 +411
plugin/skills/azure-enterprise-infra-planner/references/constraints/compute-apps.md 2022 2000 +22
plugin/skills/azure-hosted-copilot-sdk/SKILL.md 1332 500 +832
plugin/skills/azure-kubernetes/SKILL.md 2634 500 +2134
plugin/skills/azure-kubernetes/azure-kubernetes-automatic-readiness/SKILL.md 3690 500 +3190
plugin/skills/azure-kusto/SKILL.md 2152 500 +1652
plugin/skills/azure-messaging/SKILL.md 821 500 +321
plugin/skills/azure-prepare/SKILL.md 3333 500 +2833
plugin/skills/azure-prepare/references/aspire.md 4617 2000 +2617
plugin/skills/azure-prepare/references/plan-template.md 2560 2000 +560
plugin/skills/azure-prepare/references/recipes/azd/aspire.md 2275 2000 +275
plugin/skills/azure-prepare/references/recipes/azd/terraform.md 3555 2000 +1555
plugin/skills/azure-prepare/references/research.md 2274 2000 +274
plugin/skills/azure-prepare/references/resources-limits-quotas.md 3322 2000 +1322
plugin/skills/azure-prepare/references/security.md 2147 2000 +147
plugin/skills/azure-prepare/references/services/functions/bicep.md 3043 2000 +1043
plugin/skills/azure-prepare/references/services/functions/templates/recipes/composition.md 2813 2000 +813
plugin/skills/azure-prepare/references/services/functions/terraform.md 3404 2000 +1404
plugin/skills/azure-quotas/SKILL.md 3006 500 +2506
plugin/skills/azure-quotas/references/commands.md 2644 2000 +644
plugin/skills/azure-reliability/SKILL.md 5922 500 +5422
plugin/skills/azure-reliability/references/configure-multi-region.md 4729 2000 +2729
plugin/skills/azure-reliability/references/services/app-service/reliability.md 2591 2000 +591
plugin/skills/azure-resource-lookup/SKILL.md 1367 500 +867
plugin/skills/azure-resource-visualizer/SKILL.md 2122 500 +1622
plugin/skills/azure-storage/SKILL.md 1228 500 +728
plugin/skills/azure-upgrade/SKILL.md 1542 500 +1042
plugin/skills/azure-upgrade/references/languages/java/INSTRUCTION.md 2893 2000 +893
plugin/skills/azure-upgrade/references/languages/java/package-specific/com.microsoft.azure.management.md 2428 2000 +428
plugin/skills/azure-upgrade/references/languages/java/templates/PLAN_TEMPLATE.md 2411 2000 +411
plugin/skills/azure-upgrade/references/languages/java/templates/PROGRESS_TEMPLATE.md 2315 2000 +315
plugin/skills/azure-upgrade/references/languages/java/templates/SUMMARY_TEMPLATE.md 2190 2000 +190
plugin/skills/azure-upgrade/references/services/functions/automation.md 3463 2000 +1463
plugin/skills/azure-upgrade/references/services/functions/consumption-to-flex.md 2773 2000 +773
plugin/skills/azure-validate/SKILL.md 950 500 +450
plugin/skills/entra-agent-id/SKILL.md 4001 500 +3501
plugin/skills/entra-app-registration/SKILL.md 2070 500 +1570
plugin/skills/entra-app-registration/references/api-permissions.md 2545 2000 +545
plugin/skills/entra-app-registration/references/cli-commands.md 2211 2000 +211
plugin/skills/entra-app-registration/references/console-app-example.md 2752 2000 +752
plugin/skills/entra-app-registration/references/oauth-flows.md 2375 2000 +375
plugin/skills/microsoft-foundry/SKILL.md 5729 500 +5229
plugin/skills/microsoft-foundry/finetuning/SKILL.md 1375 500 +875
plugin/skills/microsoft-foundry/foundry-agent/create/create-hosted.md 7619 2000 +5619
plugin/skills/microsoft-foundry/foundry-agent/create/quick-start-hosted.md 5050 2000 +3050
plugin/skills/microsoft-foundry/foundry-agent/create/references/foundry-tool-catalog.md 10921 2000 +8921
plugin/skills/microsoft-foundry/foundry-agent/create/references/local-run.md 2122 2000 +122
plugin/skills/microsoft-foundry/foundry-agent/create/references/toolbox-reference.md 2913 2000 +913
plugin/skills/microsoft-foundry/foundry-agent/create/references/tools.md 2159 2000 +159
plugin/skills/microsoft-foundry/foundry-agent/create/references/use-toolbox-in-hosted-agent.md 4591 2000 +2591
plugin/skills/microsoft-foundry/foundry-agent/deploy/deploy.md 5009 2000 +3009
plugin/skills/microsoft-foundry/foundry-agent/eval-datasets/eval-datasets.md 2863 2000 +863
plugin/skills/microsoft-foundry/foundry-agent/eval-datasets/references/generate-seed-dataset.md 2212 2000 +212
plugin/skills/microsoft-foundry/foundry-agent/eval-datasets/references/trace-to-dataset.md 4325 2000 +2325
plugin/skills/microsoft-foundry/foundry-agent/invocations-ws/invocations-ws.md 2636 2000 +636
plugin/skills/microsoft-foundry/foundry-agent/invocations-ws/references/invocations-ws-protocol.md 2009 2000 +9
plugin/skills/microsoft-foundry/foundry-agent/invoke/invoke.md 2581 2000 +581
plugin/skills/microsoft-foundry/foundry-agent/observe/observe.md 3856 2000 +1856
plugin/skills/microsoft-foundry/foundry-agent/observe/references/continuous-eval.md 3855 2000 +1855
plugin/skills/microsoft-foundry/foundry-agent/observe/references/evaluate-step.md 2175 2000 +175
plugin/skills/microsoft-foundry/foundry-agent/observe/references/evaluation-suite-generation.md 3134 2000 +1134
plugin/skills/microsoft-foundry/foundry-agent/trace/references/kql-templates.md 2701 2000 +701
plugin/skills/microsoft-foundry/models/deploy-model/SKILL.md 1805 500 +1305
plugin/skills/microsoft-foundry/models/deploy-model/capacity/SKILL.md 1739 500 +1239
plugin/skills/microsoft-foundry/models/deploy-model/customize/SKILL.md 2235 500 +1735
plugin/skills/microsoft-foundry/models/deploy-model/customize/references/customize-workflow.md 3335 2000 +1335
plugin/skills/microsoft-foundry/models/deploy-model/preset/SKILL.md 1226 500 +726
plugin/skills/microsoft-foundry/models/deploy-model/preset/references/preset-workflow.md 5534 2000 +3534
plugin/skills/microsoft-foundry/project/create/create-foundry-project.md 2258 2000 +258
plugin/skills/microsoft-foundry/quota/quota.md 2288 2000 +288
plugin/skills/microsoft-foundry/quota/references/capacity-planning.md 2080 2000 +80
plugin/skills/microsoft-foundry/references/agent-metadata-contract.md 2217 2000 +217
plugin/skills/microsoft-foundry/references/sdk/foundry-sdk-py.md 2162 2000 +162
plugin/skills/python-appservice-deploy/SKILL.md 688 500 +188

Consider moving content to references/ subdirectories.

Automated token analysis. See skill authoring guidelines for best practices.

Copilot AI reviewed Jul 4, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes Vally --strict reachability failures for the azure-compute skill by making four existing reference docs directly reachable from SKILL.md.

Changes:

  • Add a new Reference Guides section to plugin/skills/azure-compute/SKILL.md.
  • Link the four previously-orphaned reference files via references/... paths so Vally’s orphan-file check passes.

Comment thread plugin/skills/azure-compute/SKILL.md

## Reference Guides

Looked up on demand by the workflows above (primarily VM Recommender):
This was referenced Jul 4, 2026
Open
Open
Open
Open
jongio
Jon Gallant (jongio) reviewed Jul 4, 2026
View reviewed changes

@jongio Jon Gallant (jongio) left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the fix: all four reference paths resolve correctly (
eferences/vm-families.md,
eferences/vmss-guide.md,
eferences/vm-quotas.md,
eferences/retail-prices-api.md), and those are the only files in that directory, so no further orphans are possible.

The �val CI failure is from stimulus evaluation (unrelated to orphan detection). The Markdown References check passes, confirming the link structure is valid.

No issues found with this change.

jongio
Jon Gallant (jongio) reviewed Jul 4, 2026
View reviewed changes

@jongio Jon Gallant (jongio) left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the fix: all four reference paths resolve correctly (references/vm-families.md, references/vmss-guide.md, references/vm-quotas.md, references/retail-prices-api.md), and those are the only files in that directory, so no further orphans are possible.

The eval CI failure is from stimulus evaluation (unrelated to orphan detection). The Markdown References check passes, confirming the link structure is valid.

No issues found with this change.

Disregard my previous garbled comment above (PowerShell encoding issue).

@paulyuk

Paul Yuknewicz (paulyuk) commented Jul 6, 2026

Copy link
Copy Markdown
Member Author

Hi Jon Gallant (@jongio), first business day back after the July 4th weekend. This is a small fix for the azure-compute orphan reference links and it clears the repo-wide eval lint failure that's showing red on the other pass-equity PRs. Could you give it a quick review so it can land? Thanks!

@github-actions github-actions Bot mentioned this pull request Jul 6, 2026
Closed
@JasonYeMSFT

JasonYeMSFT (JasonYeMSFT) commented Jul 6, 2026

Copy link
Copy Markdown
Member

We don't need this change. The skill is fine but vally had a buggy reference checker and they removed it in their latest release. We'll adopt their latest release to stop getting that error. #2759

@github-actions github-actions Bot mentioned this pull request Jul 9, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort, defaults to Lite
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@alex-thompson Alex Thompson (alex-thompson) Awaiting requested review from alex-thompson alex-thompson is a code owner
@rakal-dyh rakal-dyh Awaiting requested review from rakal-dyh rakal-dyh is a code owner
@joybb joybb Awaiting requested review from joybb joybb is a code owner
@RickWinter Rick Winter (RickWinter) Awaiting requested review from RickWinter RickWinter is a code owner
+1 more reviewer
@jongio Jon Gallant (jongio) jongio left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@paulyuk @JasonYeMSFT @jongio