chore: refactor skill filtering in integration tests - #3023
Merged
JasonYeMSFT (JasonYeMSFT) merged 5 commits intoAug 10, 2026
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the integration test harness’s skill-selection logic by extracting plugin/skill filtering (including optional truncation) out of agent-runner into skill-loader for improved readability and reuse.
Changes:
- Added
getSkillsForTest()to centralize which plugins/skills are loaded, and which are disabled for a run. - Updated
agent-runnerto usegetSkillsForTest()instead of duplicating filtering/truncation logic. - Kept the existing character-budget truncation behavior (via
truncateSkills) as part of the new flow.
Show a summary per file
| File | Description |
|---|---|
| tests/utils/skill-loader.ts | Adds getSkillsForTest() to compute skill directories, loaded skills metadata, and disabled skills for a test run. |
| tests/utils/agent-runner.ts | Replaces inline skill filtering/truncation with a call to getSkillsForTest() when creating the Copilot session. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 3
- Review effort level: Lite
JasonYeMSFT (JasonYeMSFT)
marked this pull request as draft
August 5, 2026 22:43
reorganize branching add unit tests
JasonYeMSFT (JasonYeMSFT)
marked this pull request as ready for review
August 6, 2026 17:03
Sai Koumudi Kaluvakolanu (saikoumudi)
previously approved these changes
Aug 6, 2026
Sai Koumudi Kaluvakolanu (saikoumudi)
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactoring code for some better readability.
Checklist
cd tests && npm test)fix:,feat:,feature:,chore:,misc:,test:,eval:tests/,npm run test:integration -- <skill>ornpm run test:vally -- --skill <skill>)Related Issues