Skip to content

fix: switch to managed identity for dashboard - #3044

Merged
JasonYeMSFT (JasonYeMSFT) merged 2 commits into
mainfrom
chuye/no-storage-key
Aug 7, 2026
Merged

fix: switch to managed identity for dashboard#3044
JasonYeMSFT (JasonYeMSFT) merged 2 commits into
mainfrom
chuye/no-storage-key

Conversation

@JasonYeMSFT

@JasonYeMSFT JasonYeMSFT (JasonYeMSFT) commented Aug 7, 2026

Copy link
Copy Markdown
Member

Description

Use managed identity for the dashboard's function app since we disabled local auth.

Checklist

  • Tests pass locally (cd tests && npm test)
  • Title has one of the prefixes: fix:, feat:, feature:, chore:, misc:, test:, eval:
  • If modifying skill descriptions: verified routing correctness with integration tests (In tests/, npm run test:integration -- <skill> or npm run test:vally -- --skill <skill>)

Related Issues

@JasonYeMSFT
JasonYeMSFT (JasonYeMSFT) marked this pull request as ready for review August 7, 2026 17:52
@JasonYeMSFT
JasonYeMSFT (JasonYeMSFT) requested a review from a team as a code owner August 7, 2026 17:52
Copilot AI lite review requested due to automatic review settings August 7, 2026 17:52

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the dashboard infrastructure to use user-assigned managed identity for Function App deployment/package access (and partially for runtime storage), aligning with the move away from shared-key (“local auth”) storage access.

Changes:

  • Added userAssignedIdentityPrincipalId parameters and wired them through dashboard/infra/main.bicep.
  • Added a Storage Blob Data Contributor role assignment for the Function App identities on the deployment storage accounts.
  • Switched Function App deployment/package storage authentication from connection string to user-assigned identity; updated the dashboard Function App AzureWebJobsStorage configuration toward identity-based settings.
Show a summary per file
File Description
dashboard/infra/modules/sync-function-app.bicep Adds MI principal ID + RBAC for deployment package auth; updates deployment auth to MI.
dashboard/infra/modules/function-app.bicep Adds MI principal ID + RBAC; updates deployment auth to MI; switches host storage settings to identity-based URIs.
dashboard/infra/main.bicep Passes principal IDs into both Function App modules.

Review details

  • Files reviewed: 3/3 changed files
  • Comments generated: 3
  • Review effort level: Lite

Comment thread dashboard/infra/modules/function-app.bicep
Comment thread dashboard/infra/modules/function-app.bicep
Comment thread dashboard/infra/modules/sync-function-app.bicep
@JasonYeMSFT
JasonYeMSFT (JasonYeMSFT) merged commit 3333acb into main Aug 7, 2026
10 checks passed
@JasonYeMSFT
JasonYeMSFT (JasonYeMSFT) deleted the chuye/no-storage-key branch August 7, 2026 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants