misc: revert additional path pattern for kusto graph plugin - #3108
Merged
JasonYeMSFT (JasonYeMSFT) merged 1 commit intoAug 24, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reverts the expanded reference-file path matching in the telemetry hook scripts to help troubleshoot a reported telemetry event-count drop by narrowing tracking back to the azure-skills (and shared .agents/skills) path patterns.
Changes:
- Removed
azure-kusto-graph-skillspath-pattern matching from the Bash telemetry hook. - Removed
azure-kusto-graph-skillspath-pattern matching from the PowerShell telemetry hook. - Simplified inline documentation/comments around recognized install paths and path-pattern blocks.
Show a summary per file
| File | Description |
|---|---|
| hooks/scripts/track-telemetry.sh | Removes kusto-graph plugin path matching from is_azure_skills_path and updates related header comments. |
| hooks/scripts/track-telemetry.ps1 | Removes kusto-graph plugin path regexes from $pathPatterns and updates related header comments. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Suppressed comments (4)
hooks/scripts/track-telemetry.sh:307
- This comment describes “azure-skills folder structure”, but
is_azure_skills_pathalso matches.agents/skills/...and a local plugin root. Updating the wording helps keep the function’s behavior understandable (especially when troubleshooting telemetry).
# Check if a path matches any known azure-skills folder structure
# Returns 0 (true) if matched, 1 (false) otherwise
is_azure_skills_path() {
local p="$1"
[[ "$p" == *".copilot/installed-plugins/"*"/azure/skills/"* ]] && return 0
[[ "$p" == *".claude/plugins/cache/azure-skills/azure/"*"/skills/"* ]] && return 0
[[ "$p" == *".claude/plugins/cache/claude-plugins-official/azure/"*"/skills/"* ]] && return 0
[[ "$p" == *"agent-plugins/github.com/microsoft/azure-skills/.github/plugins/azure-skills/skills/"* ]] && return 0
[[ "$p" == *".agents/skills/"* ]] && return 0
hooks/scripts/track-telemetry.sh:83
- The header says “Recognized azure-skills install paths”, but the list also includes the shared
.agents/skills/...path. This is misleading for readers troubleshooting path matching; consider restoring a clear azure-skills vs shared grouping (or renaming the header to be generic).
This issue also appears on line 299 of the same file.
# Recognized azure-skills install paths:
# - .copilot/installed-plugins/<catalog-name>/azure/skills/...
# (<catalog-name> is the marketplace/catalog folder the plugin was
# installed under, e.g. "awesome-copilot" — it does not necessarily
# match the plugin's own name, "azure")
hooks/scripts/track-telemetry.ps1:81
- The header says “Recognized azure-skills install paths”, but the list includes the shared
.agents/skills/...path as well. Consider restoring an explicit azure-skills vs shared grouping (or renaming the header) to avoid confusion when validating matches.
This issue also appears on line 292 of the same file.
# Recognized azure-skills install paths:
# - .copilot/installed-plugins/<catalog-name>/azure/skills/...
# (<catalog-name> is the marketplace/catalog folder the plugin was
# installed under, e.g. "awesome-copilot" — it does not necessarily
# match the plugin's own name, "azure")
hooks/scripts/track-telemetry.ps1:299
- This comment says the patterns are “Azure-skills path patterns”, but
$pathPatternsalso includes.agents/skills/and (optionally) a local plugin root. Adjusting the wording here keeps the documentation aligned with what’s actually matched.
# Azure-skills path patterns per client (used for SKILL.md and file-reference matching)
$pathPatternCopilot = '\.copilot/installed-plugins/[^/]+/azure/skills/'
$pathPatternClaude = '\.claude/plugins/cache/(azure-skills|claude-plugins-official)/azure/[0-9.]+/skills/'
$pathPatternVscodeAgentPlugins = 'agent-plugins/github\.com/microsoft/azure-skills/\.github/plugins/azure-skills/skills/'
$pathPatternAgentsSkills = '\.agents/skills/'
# Put the path patterns into an array for easier iteration
$pathPatterns = @($pathPatternCopilot, $pathPatternClaude, $pathPatternVscodeAgentPlugins, $pathPatternAgentsSkills)
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
Yun Jung Choi (yunjchoi)
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Revert expanded reference file path filter to help troubleshoot telemetry drop.
Telemetry data dropped significantly since the expanded reference file path filter was merged. Although there is no clear evidence that these changes caused it, I would like to revert them for now and see if the event count recovers. This could help us further confirm if the root cause of the drop is these changes.
Checklist
cd tests && npm test)fix:,feat:,feature:,chore:,misc:,test:,eval:tests/,npm run test:vally -- --plugin <plugin-dirname> --skill <skill>)Related Issues