Skip to content

misc: revert additional path pattern for kusto graph plugin - #3108

Merged
JasonYeMSFT (JasonYeMSFT) merged 1 commit into
microsoft:mainfrom
JasonYeMSFT:chuye/revert-track-telemetry-change
Aug 24, 2026
Merged

misc: revert additional path pattern for kusto graph plugin#3108
JasonYeMSFT (JasonYeMSFT) merged 1 commit into
microsoft:mainfrom
JasonYeMSFT:chuye/revert-track-telemetry-change

Conversation

@JasonYeMSFT

@JasonYeMSFT JasonYeMSFT (JasonYeMSFT) commented Aug 24, 2026

Copy link
Copy Markdown
Member

Description

Revert expanded reference file path filter to help troubleshoot telemetry drop.

Telemetry data dropped significantly since the expanded reference file path filter was merged. Although there is no clear evidence that these changes caused it, I would like to revert them for now and see if the event count recovers. This could help us further confirm if the root cause of the drop is these changes.

Checklist

  • Tests pass locally (cd tests && npm test)
  • Title has one of the prefixes: fix:, feat:, feature:, chore:, misc:, test:, eval:
  • If modifying skill descriptions: verified routing correctness with integration tests (In tests/, npm run test:vally -- --plugin <plugin-dirname> --skill <skill>)

Related Issues

@JasonYeMSFT
JasonYeMSFT (JasonYeMSFT) requested a review from a team as a code owner August 24, 2026 22:00
Copilot AI lite review requested due to automatic review settings August 24, 2026 22:00

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reverts the expanded reference-file path matching in the telemetry hook scripts to help troubleshoot a reported telemetry event-count drop by narrowing tracking back to the azure-skills (and shared .agents/skills) path patterns.

Changes:

  • Removed azure-kusto-graph-skills path-pattern matching from the Bash telemetry hook.
  • Removed azure-kusto-graph-skills path-pattern matching from the PowerShell telemetry hook.
  • Simplified inline documentation/comments around recognized install paths and path-pattern blocks.
Show a summary per file
File Description
hooks/scripts/track-telemetry.sh Removes kusto-graph plugin path matching from is_azure_skills_path and updates related header comments.
hooks/scripts/track-telemetry.ps1 Removes kusto-graph plugin path regexes from $pathPatterns and updates related header comments.

Review details

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Suppressed comments (4)

hooks/scripts/track-telemetry.sh:307

  • This comment describes “azure-skills folder structure”, but is_azure_skills_path also matches .agents/skills/... and a local plugin root. Updating the wording helps keep the function’s behavior understandable (especially when troubleshooting telemetry).
# Check if a path matches any known azure-skills folder structure
# Returns 0 (true) if matched, 1 (false) otherwise
is_azure_skills_path() {
    local p="$1"
    [[ "$p" == *".copilot/installed-plugins/"*"/azure/skills/"* ]] && return 0
    [[ "$p" == *".claude/plugins/cache/azure-skills/azure/"*"/skills/"* ]] && return 0
    [[ "$p" == *".claude/plugins/cache/claude-plugins-official/azure/"*"/skills/"* ]] && return 0
    [[ "$p" == *"agent-plugins/github.com/microsoft/azure-skills/.github/plugins/azure-skills/skills/"* ]] && return 0
    [[ "$p" == *".agents/skills/"* ]] && return 0

hooks/scripts/track-telemetry.sh:83

  • The header says “Recognized azure-skills install paths”, but the list also includes the shared .agents/skills/... path. This is misleading for readers troubleshooting path matching; consider restoring a clear azure-skills vs shared grouping (or renaming the header to be generic).

This issue also appears on line 299 of the same file.

#   Recognized azure-skills install paths:
#     - .copilot/installed-plugins/<catalog-name>/azure/skills/...
#       (<catalog-name> is the marketplace/catalog folder the plugin was
#       installed under, e.g. "awesome-copilot" — it does not necessarily
#       match the plugin's own name, "azure")

hooks/scripts/track-telemetry.ps1:81

  • The header says “Recognized azure-skills install paths”, but the list includes the shared .agents/skills/... path as well. Consider restoring an explicit azure-skills vs shared grouping (or renaming the header) to avoid confusion when validating matches.

This issue also appears on line 292 of the same file.

#   Recognized azure-skills install paths:
#     - .copilot/installed-plugins/<catalog-name>/azure/skills/...
#       (<catalog-name> is the marketplace/catalog folder the plugin was
#       installed under, e.g. "awesome-copilot" — it does not necessarily
#       match the plugin's own name, "azure")

hooks/scripts/track-telemetry.ps1:299

  • This comment says the patterns are “Azure-skills path patterns”, but $pathPatterns also includes .agents/skills/ and (optionally) a local plugin root. Adjusting the wording here keeps the documentation aligned with what’s actually matched.
# Azure-skills path patterns per client (used for SKILL.md and file-reference matching)
$pathPatternCopilot = '\.copilot/installed-plugins/[^/]+/azure/skills/'
$pathPatternClaude = '\.claude/plugins/cache/(azure-skills|claude-plugins-official)/azure/[0-9.]+/skills/'
$pathPatternVscodeAgentPlugins = 'agent-plugins/github\.com/microsoft/azure-skills/\.github/plugins/azure-skills/skills/'
$pathPatternAgentsSkills = '\.agents/skills/'

# Put the path patterns into an array for easier iteration
$pathPatterns = @($pathPatternCopilot, $pathPatternClaude, $pathPatternVscodeAgentPlugins, $pathPatternAgentsSkills)
  • Files reviewed: 2/2 changed files
  • Comments generated: 0
  • Review effort level: Lite

@JasonYeMSFT
JasonYeMSFT (JasonYeMSFT) merged commit d1b5b04 into microsoft:main Aug 24, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants