TryGetTidFromTargetId() fails to parse thread ID from target-id if format is like Thread 123.123 #1448

Activity

1. iyerrakesh commented on Jul 17, 2024

   

   Rakesh Iyer (iyerrakesh)

   on Jul 17, 2024

   Last edited by iyerrakesh

   More actions

   We currently have two fields in DebuggedThread object, namely Id and TargetId.

   

   We store the global numeric ID assigned to the thread by GDB in Id.
   However, we strip all the target-specific string information and only use the numeric value to store in the TargetId. This can lead to complications when we are debugging with multiple devices. The target ID may be no longer unique. The TargetId needs to be a string and we need to fetch it as is. We had to temporarily change the "target-id" field from ZE to Thread but this cannot be up-streamed to gdb.

   Also in AD7Thread that implements IDebugThread2.GetThreadId, we use TargetId to get ThreadId.
   

   MIEngine/src/MIDebugEngine/AD7.Impl/AD7Thread.cs

   Line 212 in b8bfa53

   threadId = _debuggedThread.TargetId;

   
   This method is called by AD7ExtensionMethods.
   

   MIEngine/src/OpenDebugAD7/AD7ExtensionMethods.cs

   Line 18 in b8bfa53

   thread.GetThreadId(out unsignedId);

   
   This is in turn used to identify ThreadId for Stopped Event.
   

   MIEngine/src/OpenDebugAD7/AD7DebugSession.cs

   Line 644 in b8bfa53

   ThreadId = thread.Id(),
2. Rakesh Iyer (iyerrakesh)

   added a commit that references this issue on Jul 19, 2024

   MIEngine: Convert TargetId to string

   ...

   84e9db6