This repository was archived by the owner on Nov 16, 2023. It is now read-only.
Repository navigation
This repository was archived by the owner on Nov 16, 2023. It is now read-only.
Typescript errors don't break build #33
Description
When using @babel/preset-typescript with babel-loader (webpack), a typescript error does not break the build. It compiles no matter what which renders typescript useless. When using just webpack and ts-loader I get the desired result of seeing errors in the terminal and a broken build when there is a typescript issue. Is this the intended behavior using typescript and babel in webpack ?
Activity
[-]Typescript errors don't error in build[/-][+]Typescript errors don't break build[/+]johnknoop commentedon Jan 31, 2019
Ben Bissonnette (@benjamingeorge) That is the intended behaviour. Babel just strips all the ts-stuff out. That's why you need the manual typechecking as well.
gilamran commentedon Feb 1, 2019
Sounds like a bad plan... Would you want to build your C#/C++ project without type checking?
In my opinion, TypeScript should stop the build on error.
juanpicado commentedon Mar 12, 2019
Does anyone know whether there is a way to break the build or display warnings in build time (webpack)?
frankandrobot commentedon Apr 24, 2019
Good question Juan Picado (@juanpicado), is the solution to use babel-loader with ts-loader? Or something else?
Update: related: https://stackoverflow.com/questions/54675587/babel-typescript-doesnt-throw-errors-while-webpack-build . They recommend: https://github.com/Realytics/fork-ts-checker-webpack-plugin
juanpicado commentedon May 9, 2019
Uriel Avalos (@frankandrobot) I've been testing that plugin for a while and seems run the type checking in parallel and not in sync with the webpack process. Sometimes throws errors before webpck finish the hot reload build. It helps, but not the definitive solution.
MonkeyDo commentedon Dec 10, 2020
Here's another plugin that can achieve the same result: fork-ts-checker-webpack-plugin
nyngwang commentedon Apr 7, 2022
Gil Amran (@gilamran): If you are a JS library maintainer, do you want to see your library fails to build during the migration? I don't think you get the point of what John Knoop (@johnknoop) was saying.
This is just an additional feature that
ts-loaderprovides. The point of TypeScript is you don't need to do it right at once.