Skip to content

RtcRtpEncodingParameters.maxFramerate not included #1380

Open

Description

Hi,

As I was going through the definitions, it seems like in Typescript 4.3 or @types/web@0.0.1 maxFramerate was not included. At the time, it looks like maxFramerate did not have enough support among multiple browsers. Since then, the browser support has increased sufficiently: https://developer.mozilla.org/en-US/docs/Web/API/RTCRtpEncodingParameters/maxFramerate.

I went through the contribution guidelines and confirmed that maxFramerate is not included in inputfiles/removedTypes.jsonc. The exclusion of maxFramerate is a breaking change for us. There is another instance of this being a breaking change: #991 (comment) for another dev.

I will like to know if maxFramerate can be added back to the types?

Activity

  1. saschanaz commented on Sep 18, 2022

    @saschanaz
    Contributor

    This is because people are not sure it's interop-ready: w3c/webrtc-extensions#108

    That said, the implementation detail doesn't matter for TypeScript. I'll accept a PR for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions