2.0 @types declarations compiled despite ignore listing in tsconfig #11257

Activity

1. mhegazy commented on Sep 29, 2016

   

   Mohamed Hegazy (mhegazy)

   on Sep 29, 2016

   Contributor

   More actions

   Types (@types) are automatically included in the compilation. to exclude them, add "types": [] to your tsconfig.json

   👍React with 👍1Reacted by Mathieu Savy

   ❤️React with ❤️1Reacted by Mathieu Savy
2. Mohamed Hegazy (mhegazy)

   added

   QuestionAn issue which isn't directly actionable in codeAn issue which isn't directly actionable in code

   on Sep 29, 2016
3. georgeedwards commented on Sep 30, 2016

   

   georgeedwards

   on Sep 30, 2016

   Author

   More actions

   Mohamed Hegazy (@mhegazy) Even with this as my tsconfig:

   {
       "compilerOptions": {
           "target": "es6",
           "module": "commonjs",
           "moduleResolution": "node",
           "sourceMap": true,
           "emitDecoratorMetadata": true,
           "experimentalDecorators": true,
           "removeComments": false,
           "noImplicitAny": false
       },
       "types": [],
       "exclude": [
           "../node_modules"
       ]
   }
   

   I still get errors, e.g.

   [1] node_modules/@types/core-js/index.d.ts(21,14): error TS2300: Duplicate identifier 'PropertyKey'.

   [1] node_modules/@types/core-js/index.d.ts(85,5): error TS2687: All declarations of 'name' must have identical modifiers.
   [1] node_modules/@types/core-js/index.d.ts(145,5): error TS2403: Subsequent variable declarations must have the same type. Variable '[Symbol.unscopables]' must be of type '{ copyWithin: boolean; entries: boolean; fill: boolean; find: boolean; findIndex: boolean; keys: ...', but here has type 'any'.

   [1] node_modules/@types/core-js/index.d.ts(262,5): error TS2687: All declarations of 'flags' must have identical modifiers.
4. lucipacurar commented on Sep 30, 2016

   

   Lucian Pacurar (lucipacurar)

   on Sep 30, 2016

   More actions

   {
       "compilerOptions": {
           "target": "es6",
           "module": "commonjs",
           "moduleResolution": "node",
           "sourceMap": true,
           "emitDecoratorMetadata": true,
           "experimentalDecorators": true,
           "removeComments": false,
           "noImplicitAny": false,
           "types": []
       },
       "exclude": [
           "../node_modules"
       ]
   }
   

   I believe types should be inside compilerOptions

   👍React with 👍7Reacted by georgeedwards, Benjamin Schwitter, Atsushi Miyake, Vayne Tsai, Sos Sargsyan, Hector Leiva and Volker Rose
5. georgeedwards

   closed this as completedon Sep 30, 2016
6. microsoft

   locked and limited conversation to collaborators on Jun 19, 2018