Skip to content

Decorate all properties with type metadata in TypeScript #11861

Closed

Description

I'm working on a JSON Object-Mapper which would parse a JSON string and produce typed objects, i.e.

class Bar {}
class Foo {
    bar: Bar;
}
let json = '{"bar":{}}';
let foo = mapper.fromString(json, Foo);
expect(foo instanceof Foo).toBe(true);
expect(foo.bar instanceof Bar).toBe(true);

For this I need design:type metadata for all properties, but I see it's emitted only if a property is decorated (also a bogus decorator will do), e.g.

class Foo {                 var Foo = (function () {
    bar: Bar;                   function Foo() {
}                               }
                                return Foo;
                            }());

function bogus(t, k) {}

class Foo {                 var Foo = (function () {
    @bogus bar: Bar;            function Foo() {
}                               }
                                __decorate([
                                    bogus, 
                                    __metadata('design:type', Bar)
                                ], Foo.prototype, "bar", void 0);
                                return Foo;
                            }());

It would be very useful to have a compiler option to enable the implicit metadata decoration for all design:* metadata, without the need of an additional decorator.

Activity

  1. mhegazy commented on Oct 26, 2016

    @mhegazy
    Contributor

    Metadata is just a decorator, just one that the compiler emits. decorating all propoerties/method/classes would explode the size of the output, will cause a decorator call for every declaration. it is not clear that there is much utility of this despite the cost. you can see more discussion about why this does not really work for the general case in #3628.

  2. added
    SuggestionAn idea for TypeScript
    DeclinedThe issue was declined as something which matches the TypeScript vision
    on Oct 26, 2016
  3. locked and limited conversation to collaborators on Jun 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    DeclinedThe issue was declined as something which matches the TypeScript visionSuggestionAn idea for TypeScript

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions