Repository navigation
Completion should prefer literal types in union types #13614
Description
Activity
Andy (Andrewkraft) (@Andy-MS), from your comment in the other thread, it sounds like someone chose to make a regression in tooling in exchange for a compiler optimization. For a language like TypeScript where one of its largest features is good tooling, I think this is a mistake.
The TypeStyle project leverages literal types to provide good auto-completion for css property values. A lot of properties have exact keywords for which type ahead support is great. However, a lot of these can also take units like 3px which can't be described to the type system, so we have to fallback to a string.
Here is an issue recently brought by a developer using TypeStyle: typestyle/typestyle#104
What would it take to restore this behavior?
Reacted by Patrick Lienau, Braden Snell and Fredrik NicolI agree with B1t (@notoriousb1t) . This is a feature I really want; there's tons of instances where it can make writing quality code quicker—one of the things about TypeScript that makes the DX so great. Granted, the spec does denote that in such cases the union would get widened to
string, yet, those suggestions are still highly relevant. Can't there be some convenient deviation from the what the type checker derives.So all we see when querying the type checker for the type of x is string. So, this can't be fixed.
— Andy (Andrewkraft) (@Andy-MS)That's such a cop-out man. I'm not familiar with the internals of the type checker, but surely some metadata could be supplied to the completion provider alongside the results from the type checker.
Reacted by Braden Snell- locked and limited conversation to collaborators
on Jun 19, 2018
TypeScript Version: 2.2.0-dev.20170120
Code
Expected behavior:
The auto completion list shows 'inline-block' followed by general string suggestions
Actual behavior:
The auto completion list shows general string suggestions none of which are 'inline-block;