Repository navigation
Feedback to improve compileOnSave with tsserver. #17630
Description
I have implemented inside Eclipse compile on save with tsserver by consuming compileOnSaveAffectedFileList and compileOnSaveEmitFile commands. It works great but I think we could again improved it
For compileOnSaveAffectedFileList:
compileOnSaveAffectedFileListshould throw error when the given file is excluded of tsconfig.json. It will give the capability to display an error dialog when user wishes to compile a ts file which is excluded by tsconfig.json- in some case, tsserver
compileOnSaveAffectedFileListreturns *.d.ts files (see ttps://github.com/ ts.TypeScriptNoContentAvailableException on compile angelozerr/typescript.java#190#issuecomment-317876026) those *.d.ts files must be ignored for compilation.
For compileOnSaveEmitFile:
- the reponse
compileOnSaveEmitFileshould return diagnostics errors. I had to call the two tsserver commandssyntacticDiagnosticsSyncandsemantacticDiagnosticsSyncafter the call ofcompileOnSaveEmitFileto display errors in the Eclipse "Problem View" - the reponse
compileOnSaveEmitFileshould return the emited files path (js and *.js.map). In Eclipse case it's very helpful because I could refresh the files.
Activity
[-]Feedback to improve compile on save with tsserver.[/-][+]Feedback to improve compileOnSave with tsserver.[/+]mhegazy commentedon Aug 29, 2017
do not you have this already from
projectInfo?I would say this is a bug.
I would disassociate errors from compile-on-save.
seems like a reasonable request. PRs welcomed.
mhegazy commentedon Oct 27, 2017
PRs welcomed for changing
compileOnSaveEmitFileto return a list of generated files.