strictNullChecks - property accesses on string index signatures should narrow

TypeScript Version: 2.6.0-dev.20170819

Code

// process.env is defined as { [key: string]: string | undefined } in @types/node

// Expected
console.log(process.env.MY_ENV_VAR.length);  // TS2532: Object is possibly 'undefined'

if (process.env.MY_ENV_VAR) {
  // Unexpected - process.env.MY_ENV_VAR is defined here
  console.log(process.env.MY_ENV_VAR.length); // TS2532: Object is possibly 'undefined'
}

/* ------------------------------------------------------------------------------------- */

const collection: { [id: string]: string } = {};

console.log(collection.someVar.length); // No error

Expected behavior:
When using strictNullChecks :

The compiler should not emmit an TS2532: Object is possibly 'undefined' error when accessing an index of an object defined as { [key: string]: string | undefined } inside a guard.
The compiler should emmit an error when accessing an index of an object defined as { [key: string]: string } inside a guard without checking it first.

Actual behavior:
Please see code sample.

The second issue is tracked by #13778.

It's also surprising that assigning the (theoretically) type narrowed object to a different variable removes the error:

if (process.env.MY_ENV_VAR) {
  console.log(process.env.MY_ENV_VAR.length); // ERROR
}

const v = process.env.MY_ENV_VAR;
if (v) {
  console.log(v.length); // NO ERROR
}

v is seemingly equivalent to process.env.MY_ENV_VAR; why do they behave differently?

Another seemingly related error (TS 3.4.5):

declare const foo: {
    [id: string]: {
        bar?: {
            baz?: boolean;
        }
    }
};
const a1 = foo.id && foo.id.bar && foo.id.bar.baz; // works fine
const key = 'id';
const a2 = foo[key] && foo[key].bar && foo[key].bar.baz; // error: Object is possibly 'undefined'

playground

Just looking at old issues; this one was fixed by #19838.

Navigation Menu

Repository navigation

strictNullChecks - property accesses on string index signatures should narrow #17960

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

strictNullChecks - property accesses on string index signatures should narrow #17960

Description

Activity

mhegazy commented on Aug 22, 2017

ithinkihaveacat commented on Aug 27, 2017

thorn0 commented on May 7, 2019

jakebailey commented on Jul 9, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions