Folding ranges not returned for highly nested functions #25596

Activity

1. Matt Bierner (mjbvz)

   self-assigned this

   on Jul 12, 2018
2. Matt Bierner (mjbvz)

   added

   Needs More InfoThe issue still hasn't been fully clarifiedThe issue still hasn't been fully clarified

   on Jul 12, 2018
3. mjbvz commented on Jul 12, 2018

   

   Matt Bierner (mjbvz)

   on Jul 12, 2018 · Hidden as outdated

   Author

   show commentMore actions
4. mjbvz commented on Jul 12, 2018

   

   Matt Bierner (mjbvz)

   on Jul 12, 2018

   ContributorAuthor

   More actions

   From Alex Ryltsov (@ryaa) on July 11, 2018 4:16

   Here is the file (just remove .txt extension and open the file in VS Code) and the screenshot.
   Note that that there are collapsing icons at the line 1380, 1390, 1411 and no collapsing icon for the line 1400, 1422, 1433 etc.)

   add-multiple-photos-using-preview.spec.ts.txt

   
5. Matt Bierner (mjbvz)

   added

   VS Code TrackedThere is a VS Code equivalent to this issueThere is a VS Code equivalent to this issue

   and removed

   Needs More InfoThe issue still hasn't been fully clarifiedThe issue still hasn't been fully clarified

   on Jul 12, 2018
6. Matt Bierner (mjbvz)

   removed their assignment

   on Jul 12, 2018
7. mjbvz commented on Jul 12, 2018

   

   Matt Bierner (mjbvz)

   on Jul 12, 2018

   Last edited by mjbvz

   ContributorAuthor

   More actions

   Looked through the file and tried narrow down the root cause. Here's a more minimal example:

   describe('testing methods', () => {
       describe('addPhotoAttachment', () => {
           describe('when isPhotoBeingTaken is false', () => {
               describe('when platform.ready resolves', () => {
                   describe('when deviceUtils.isRunningOnRealDevice returns true', () => {
                       describe('when cameraPreview.takePicture resolves', () => {
                           describe('when locationUtils.getCurrentLocation resolves', () => {
                               describe('when coordinates are defined', () => {
                                   describe('when exifUtils.setCoordinatesToBase64String resolves', () => {
                                       describe('when fileUtils.saveBase64StringAsBinaryFile rejects', () => {
                                           it('should NOT invoke thumbnailCreator.thumbnailify', () => {
                                               // no collapse on this function
                                           });
                                       });
                                   });
                               });
                           });
                       });
                   });
               });
           });
       });
   });

   Seems that TS Server stops returning spans after a folding level of 10?
8. Matt Bierner (mjbvz)

   changed the title [-] Folding icons next to the line numbers are not shown in the nested block[/-] [+]Folding ranges not returned for highly nested functions[/+] on Jul 12, 2018
9. Mohamed Hegazy (mhegazy)

   added

   Domain: LS: OutliningRelates to multi-line regions that editors can collapseRelates to multi-line regions that editors can collapse

   on Jul 12, 2018
10. Mohamed Hegazy (mhegazy)

    assigned

    Ben Lichtman (uniqueiniquity)

    on Jul 12, 2018
11. mhegazy commented on Jul 12, 2018

    

    Mohamed Hegazy (mhegazy)

    on Jul 12, 2018

    Contributor

    More actions

    We have a limit on depth. this avoid excessively large response from the server for large files. the current depth is 40, but that includes every node in the tree (e.g. call expression, lambdas, etc..).

    That said, we could look into increasing it.. but from our previous experience it can affect perf fairly quickly on large files.
12. Mohamed Hegazy (mhegazy)

    added

    SuggestionAn idea for TypeScriptAn idea for TypeScript

    Needs ProposalThis issue needs a plan that clarifies the finer details of how it could be implemented.This issue needs a plan that clarifies the finer details of how it could be implemented.

    on Jul 12, 2018
13. ryaa commented on Jun 24, 2020

    

    Alex Ryltsov (ryaa)

    on Jun 24, 2020

    More actions

    Is it possible to make this value configurable and allow the user to set it to a higher value, if required?

    👍React with 👍1Reacted by bhaynes777
14. Ben Lichtman (uniqueiniquity)

    removed their assignment

    on Aug 10, 2021
15. vincentvictoria commented on Aug 18, 2021

    

    Vincent (vincentvictoria)

    on Aug 18, 2021

    More actions

    Just a notification will be greatly helpful to prevent any confusions from users. When I experienced this issue for the first time, I thought there was a syntax error in my code which prevents folding regions to occur. Then I found out the limit by gradually removing functions manually.

    👍React with 👍1Reacted by Alex Ryltsov
16. bhaynes777 commented on Oct 24, 2022

    

    bhaynes777

    on Oct 24, 2022

    More actions

    I would love to see this fixed. As in mjbvz's example, it is really easy to run into this with nested unit test describe blocks, and folding is really nice when trying to navigate large unit test files.

    👍React with 👍1Reacted by Alex Ryltsov