Repository navigation
Suggestions not accepted when using commit characters #31244
Description
- VSCode Version: 1.33.1
- OS Version: 10.14.4
Steps to Reproduce:
mkdir testcode --disable-extensions --user-data-dir temp test- Create new JS file
const mySpecialVar = 1;
const foo = mySpec<cursor>
When suggestions appear, press ; (commit character).
Expected: suggestion is accepted + ; is inserted.
Actual: ; is inserted.
OTOH, this does work as expected:
const mySpecialVar = 1;
const foo = 1 + mySpec<cursor>
Does this issue occur when all extensions are disabled?: Yes/No
Activity
mjbvz commentedon May 3, 2019
The root cause of this is that the completion info at this location returns
isNewIdentifierLocation: trueso we disable all commit characters.We could either look into fixing this case (although I'm not sure if it would regress some other completion behavior), or add commit characters to the tsserver #27623
mjbvz commentedon May 3, 2019
Alternatively, we could always treat
;as a commit character. One case where that could possibly cause issues is declaring a property or method in class:duzenko commentedon May 18, 2023