Repository navigation
Error in 'getExportEqualsLocalSymbol' during 'documentHighlights' #39584
Description
This issue comes from crash dumps in telemetry. We've tried to de-duplicate issues on a best-effort basis, comparing the sequence of methods called and the command requested while ignoring line numbers.
TypeScript version prefix: 3.9.6
VSCode version: 1.47.0
Command requested: documentHighlights
Hitting sessions: 5942
Five line hash: 484743baaede160b2fba00a271553832
Stack:
at getExportEqualsLocalSymbol (tsserver.js:115456:33)
at getImport (tsserver.js:115427:38)
at getImportOrExportSymbol (tsserver.js:115343:68)
at getImportOrExportReferences (tsserver.js:116838:56)
at getReferencesAtLocation (tsserver.js:116768:17)
at getReferencesInContainer (tsserver.js:116712:21)
at getReferencesInContainerOrFiles (tsserver.js:116266:21)
at getReferencedSymbolsForSymbol (tsserver.js:116257:21)
at getReferencedSymbolsForNode (tsserver.js:116054:34)
at getReferenceEntriesForNode (tsserver.js:115773:40)
at getSemanticDocumentHighlights (tsserver.js:114419:57)
at getDocumentHighlights (tsserver.js:114407:20)
at getDocumentHighlights (tsserver.js:138994:42)
at Session.getDocumentHighlights (tsserver.js:148637:71)
at _a.<computed> (tsserver.js:148020:61)
at <anonymous> (tsserver.js:149553:88)
at Session.executeWithRequestId (tsserver.js:149544:28)
at Session.executeCommand (tsserver.js:149553:33)
at Session.onMessage (tsserver.js:149577:35)
at <anonymous> (tsserver.js:150893:27)
at unknown (suppressed.js:203:13)
at unknown (suppressed.js:316:10)
at unknown (suppressed.js:461:12)
at unknown (suppressed.js:172:10)
at unknown (suppressed.js:203:13)
at unknown (suppressed.js:295:12)
at unknown (suppressed.js:276:11)
at unknown (suppressed.js:210:10)
at unknown (suppressed.js:166:17)
Activity
typescript-bot commentedon Jul 27, 2020
This issue reproduced in the following context:
TypeScript version prefix: 3.9.7
VSCode version: 1.48.0-insider
Command requested: documentHighlights
Hitting sessions: 103
Five line hash: 484743baaede160b2fba00a271553832
Stack:
minestarks commentedon Jul 31, 2020
Ryan Cavanaugh (@RyanCavanaugh) repro @ https://github.com/microsoft/tsserverfuzzer/issues/247
typescript-bot commentedon Aug 24, 2020
This issue reproduced in the following context:
TypeScript version prefix: 4.0.2
VSCode version: 1.49.0-insider
Command requested: documentHighlights
Hitting sessions: 144
Five line hash: 484743baaede160b2fba00a271553832
Stack:
typescript-bot commentedon Sep 28, 2020
This issue reproduced in the following context:
TypeScript version prefix: 4.0.3
VSCode version: 1.50.0-insider
Command requested: documentHighlights
Hitting sessions: 192
Five line hash: 484743baaede160b2fba00a271553832
Stack:
typescript-bot commentedon Nov 30, 2020
This issue reproduced in the following context:
TypeScript version prefix: 4.1.2
VSCode version: 1.52.0-insider
Command requested: documentHighlights
Hitting sessions: 224
Five line hash: 484743baaede160b2fba00a271553832
Stack:
typescript-bot commentedon Feb 15, 2021
This issue reproduced in the following context:
TypeScript version prefix: 4.1.5
VSCode version: 1.53.2
Command requested: documentHighlights
Hitting sessions: 4236
Five line hash: 484743baaede160b2fba00a271553832
Stack:
minestarks commentedon Feb 17, 2021
Probably fixed, no repro since August https://github.com/microsoft/tsserverfuzzer/issues/263
typescript-bot commentedon Mar 1, 2021
This issue reproduced in the following context:
TypeScript version prefix: 4.2.2
VSCode version: 1.53.2
Command requested: documentHighlights
Hitting sessions: 114
Five line hash: 484743baaede160b2fba00a271553832
Stack:
typescript-bot commentedon Mar 15, 2021
This issue reproduced in the following context:
TypeScript version prefix: 4.2.3
VSCode version: 1.55.0-insider
Command requested: documentHighlights
Hitting sessions: 6795
Five line hash: 484743baaede160b2fba00a271553832
Stack:
typescript-bot commentedon Apr 19, 2021
This issue reproduced in the following context:
TypeScript version prefix: 4.2.4
VSCode version: 1.56.0-insider
Command requested: documentHighlights
Hitting sessions: 269
Five line hash: 484743baaede160b2fba00a271553832
Stack:
tsugabloom commentedon May 6, 2021
There's a lot of "unknown (suppressed.js)" in the bot comments so I'll post a full stacktrace here since the issue keeps happening to me:
I know this isn't VSCode, it's VSCodium, but the line/columns for tsserver.js are exactly the same so I think it's the same issue.
typescript-bot commentedon Jun 7, 2021
This issue reproduced in the following context:
TypeScript version prefix: 4.3.2
VSCode version: 1.57.0-insider
Command requested: documentHighlights
Hitting sessions: 235
Five line hash: 484743baaede160b2fba00a271553832
Stack:
typescript-bot commentedon Jul 8, 2021
This issue reproduced in the following context:
TypeScript version prefix: 4.3.5
VSCode version: 1.58.0-insider
Command requested: documentHighlights
Hitting sessions: 194
Five line hash: 484743baaede160b2fba00a271553832
Stack:
RyanCavanaugh commentedon Jul 21, 2021
heyheyhello we're having trouble reproducing this; do you have a repro project you could share?
tsugabloom commentedon Jul 22, 2021
Unfortunately I don't, it's all private code. I tried to reproduce this for a while last night by readjusting my tsconfig to match what I had back in May. I tried both TS 4.3.5 and TS 4.2.1 but never had the same error come up; I get a new, different, error this time for the same actions (logs attached below). VSCode has updated a few times which might be why the error is different...
Very shortly after posting #39584 (comment) I stopped trying the tsconfig that caused the error. I thought I was just overloading the TS server, I don't blame it.
Here's what I was trying to do: My team develops in a monorepo and we publish internal packages for other teams to use. Many teams at our company do this. When I started working here I noticed every team publishes the code as minified+polyfilled webpack bundles even though they develop the source code in TypeScript... This meant ctrl+clicking an import would open up the meaningless minified code from node_modules. Teammates said I should just read source code in our GitLab... Instead, I tried doing a git checkout of few teams' repos and used a jsconfig.json to redirect imports to the source code. The idea was that I'd get readable code when I ctrl+click imports and I'd get properly typed imports since the other teams develop in TS! (We had yet to start developing in TS at the time, hence the jsconfig.json; today we have tsconfig).
Maybe you'd agree it's a bad idea: each repo is huge and has many packages and may have multiple tsconfigs.
I'd hover on an import statement and it'd crash.
Here's a screenshot I found from back in May of the jsconfig. I'm using
../to access a neighbouring repo outside of the current repo and reach into theirsrc/folders. The current repo/workspace is my team's "dashboard-enterprise" repo and we often use code from another team, "dashboard-framework", which I'm trying to link to here:Last night I tired it again and was very surprised to see it work! It's a bit slow, but it works! I had 20 or so
paths: []listed in our tsconfig (hascheckJs: true) and ctrl+clicking showed the source code most of the time. I still don't recommend this to anyone - it's a lot of work for the TS server.If you're curious, the new error is about not being able to find the file path (even though it's the file I'm staring at in my editor). Similar to the error in May, both only happen when I hover on an import such as
... from '@splunk/dashboard-utils/xyz';.vscode-ts-error-4.1.2.log
vscode-ts-error-4.3.5.log
TL;DR This error doesn't happen to me anymore and I was probably asking for it by misusing TypeScript at the time. I try to be nicer to the TS server these days.
Thanks!
typescript-bot commentedon Sep 6, 2021
This issue reproduced in the following context:
TypeScript version prefix: 4.4.2
VSCode version: 1.60.0-insider
Command requested: documentHighlights
Hitting sessions: 7373
Five line hash: 484743baaede160b2fba00a271553832
Stack:
typescript-bot commentedon Sep 27, 2021
This issue reproduced in the following context:
TypeScript version prefix: 4.4.3
VSCode version: 1.61.0-insider
Command requested: documentHighlights
Hitting sessions: 10760
Five line hash: 484743baaede160b2fba00a271553832
Stack:
typescript-bot commentedon Nov 29, 2021
This issue reproduced in the following context:
TypeScript version prefix: 4.5.2
VSCode version: 1.63.0-insider
Command requested: documentHighlights
Hitting sessions: 217
Five line hash: 484743baaede160b2fba00a271553832
Stack:
typescript-bot commentedon Dec 20, 2021
This issue reproduced in the following context:
TypeScript version prefix: 4.5.4
VSCode version: 1.63.2
Command requested: documentHighlights
Hitting sessions: 5536
Five line hash: 484743baaede160b2fba00a271553832
Stack:
typescript-bot commentedon Jan 31, 2022
This issue reproduced in the following context:
TypeScript version prefix: 4.5.5
VSCode version: 1.63.2
Command requested: documentHighlights
Hitting sessions: 133
Five line hash: 484743baaede160b2fba00a271553832
Stack:
typescript-bot commentedon Mar 7, 2022
This issue reproduced in the following context:
TypeScript version prefix: 4.6.2
VSCode version: 1.65.0
Command requested: documentHighlights
Hitting sessions: 6207
Five line hash: 484743baaede160b2fba00a271553832
Stack:
typescript-bot commentedon Apr 4, 2022
This issue reproduced in the following context:
TypeScript version prefix: 4.6.3
VSCode version: 1.66.0-insider
Command requested: documentHighlights
Hitting sessions: 8536
Five line hash: 484743baaede160b2fba00a271553832
Stack:
typescript-bot commentedon Jun 13, 2022
This issue reproduced in the following context:
TypeScript version prefix: 4.7.3
VSCode version: 1.68.0-insider
Command requested: documentHighlights
Hitting sessions: 5377
Five line hash: 484743baaede160b2fba00a271553832
Stack: