Skip to content

Enable TS Server plugins on web  #47376

Closed
#47377
Closed
Enable TS Server plugins on web #47376
#47377
Assignees
rbuckton
Labels
CommittedThe team has roadmapped this issueSuggestionAn idea for TypeScript
Milestone
TypeScript 4.8.0

Description

@mjbvz
Matt Bierner (mjbvz)
opened on Jan 11, 2022

For microsoft/vscode#140455

A few key VS Code extensions — such as IntelliCode — are powered by TS Server plugins. Currently we don't support loading these plugins at all on web versions of TypeScript

This feature request tracks enabling plugins from extensions on vscode.dev and GitHub.dev. We don't plan to support plugins from the workspace since these require running npm install

Activity

  1. mjbvz commented on Jan 11, 2022

    @mjbvz
    Matt Bierner (mjbvz)
    on Jan 11, 2022
    ContributorAuthor

    At the moment VS Code doesn't even try to initialize plugins with the server. However once I remove this check on the VS Code side, the code starts failing at require not being implemented:

    TypeScript/src/webServer/webServer.ts

    Line 139 in c0796c1

    require: () => ({ module: undefined, error: new Error("Not implemented") }),

  2. mjbvz commented on Jan 11, 2022

    @mjbvz
    Matt Bierner (mjbvz)
    on Jan 11, 2022
    ContributorAuthor

    I wonder if we need a browser version of these plugins too, similar to what VS Code does for extensions in browsers

    • We wouldn't try executing code the relies on node. Instead plugin authors would have to opt-in
    • Authors could easily vary their implementation between node and browser
    • We could require the plugin be compiled to a single file, just like we do for vscode extensions in browsers
  3. Matt Bierner (mjbvz)
    added a commit that references this issue on Jan 11, 2022

    Prototyping TS Server plugins on web

    ba3586a
  4. Ryan Cavanaugh (RyanCavanaugh)
    assigned
    Daniel Rosenwasser (DanielRosenwasser)
    on Jan 13, 2022
  5. Ryan Cavanaugh (RyanCavanaugh)
    added
    CommittedThe team has roadmapped this issue
    SuggestionAn idea for TypeScript
    on Jan 13, 2022

  6. mjbvz commented on Feb 16, 2022

    @mjbvz
    Matt Bierner (mjbvz)
    on Feb 16, 2022
    ContributorAuthor

    I've cleaned up my prototype in #47377 quite a bit. Noteworthy changes:

    • Plugins are now only loaded if they have a browser field in their package.json
    • Plugins are loaded using import(...) in web
    • Plugins on web must be compiled to a module that can be imported

    I think web enabled plugins are good opportunity to move plugins to adopt modern JS practices. Trying to load plugins synchronously on web is also very ugly as my original prototype showed

  7. Ron Buckton (rbuckton)
    closed this as completedin #47377on Jun 14, 2022

  8. leti367 commented on Jun 16, 2022

    @leti367
    Lei T (leti367)
    on Jun 16, 2022
    Member

    Thanks all for the help. Ron Buckton (@rbuckton) Since this change is already merged, do you have any idea when would this be available?

  9. RyanCavanaugh commented on Jun 16, 2022

    @RyanCavanaugh
    Ryan Cavanaugh (RyanCavanaugh)
    on Jun 16, 2022
    Member

    PRs merged today will be in the nightly build starting immediately the following day, and also in 4.8 Beta (plus any subsequent release)

  10. Daniel Rosenwasser (DanielRosenwasser)
    assigned
    Ron Buckton (rbuckton)
    and unassigned
    Daniel Rosenwasser (DanielRosenwasser)
    on Jun 16, 2022
  11. Daniel Rosenwasser (DanielRosenwasser)
    added this to the TypeScript 4.8.0 milestone on Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

CommittedThe team has roadmapped this issueSuggestionAn idea for TypeScript

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions