Remove internal uses of "namespace barrel" modules, untangle repo #51443

Activity

1. jakebailey commented on Nov 8, 2022

   

   Jake Bailey (jakebailey)

   on Nov 8, 2022

   MemberAuthor

   More actions

   Low hanging fruit for untangling: typeHasCallOrConstructSignatures is defined as a helper, but is then used by the checker. This should be flipped and that's one cycle down.
2. Jake Bailey (jakebailey)

   self-assigned this

   on Nov 8, 2022
3. Daniel Rosenwasser (DanielRosenwasser)

   added

   InfrastructureIssue relates to TypeScript team infrastructureIssue relates to TypeScript team infrastructure

   on Nov 8, 2022
4. a-tarasyuk commented on Nov 11, 2022

   

   Oleksandr Tarasiuk (a-tarasyuk)

   on Nov 11, 2022

   Last edited by a-tarasyuk

   Contributor

   More actions

   While this does help us transition to modules, internally, this is a gross hack and makes it hard for us to start splitting the codebase up

   Jake Bailey (@jakebailey) Do you mean it's better to use

   // @filename: core.ts
   import { Debug } from "./debug";
   import { __String, CharacterCodes, Queue, TextSpan, UnderscoreEscapedMap } from "./types";
   import { Comparer, Comparison, EqualityComparer, MapLike, Push, SortedArray, SortedReadonlyArray } from "./corePublic";
   import { isWhiteSpaceLike } from "./scanner";
   ....

   instead of

   // @filename: core.ts
   import {
       __String, CharacterCodes, Comparer, Comparison, Debug, EqualityComparer, isWhiteSpaceLike,
       MapLike, Push, Queue, SortedArray, SortedReadonlyArray, TextSpan,
       UnderscoreEscapedMap,
   } from "./_namespaces/ts";
   ...

   ?

   Or do you mean that we need to avoid import * as ts from "./_namespaces/ts";?
5. jakebailey commented on Nov 11, 2022

   

   Jake Bailey (jakebailey)

   on Nov 11, 2022

   MemberAuthor

   More actions

   Yes, the first one, not the last two. Reasons being:

   1. This is how we would have written things if we had been modules from the start.
   2. By going through the barrels, we make cycles harder to resolve. For example, core.ts should not be depending on scanner.ts. That code should be moved.
6. jakebailey commented on Aug 25, 2026

   

   Jake Bailey (jakebailey)

   on Aug 25, 2026

   MemberAuthor

   More actions

   We are now Go, so this isn't happening
7. Jake Bailey (jakebailey)

   closed this as not plannedon Aug 25, 2026