Repository navigation
It's not clear from metaModel.json that MessageActionItem can contain arbitrary additional fields #2148
Description
The generator in https://github.com/microsoft/lsprotocol uses metaModel.json as the source of truth about the LSP protocol.
While the docs for ClientShowMessageActionItemOptions.additionalPropertiesSupport indicate that MessageActionItem objects can contain arbitrary additional attributes beyond what is shown in the spec, the description of MessageActionItem itself doesn't indicate this:
{
"name": "MessageActionItem",
"properties": [
{
"name": "title",
"type": {
"kind": "base",
"name": "string"
},
"documentation": "A short title like 'Retry', 'Open Log' etc."
}
]
},I think it would be more standard to have an optional data field of type LSPAny, like on the Diagnostic object.
Is there any way that we can make this aspect of MessageActionItem clear in the json spec so tools that consume metaModel.json can support it correctly?
Related:
Activity
dbaeumer commentedon Jun 4, 2025
I agree on the
datafiled. The reason it is that way is thatMessageActionItemsare available since a very long time and that was added for backwards compatibility since servers added additional properties :-(.All I can think of right now is to add a property
supportCustomPropertiesto these types.dbaeumer commentedon Jun 4, 2025
Would that work?
debonte commentedon Jun 4, 2025
Yes, that should work, thanks!
Two questions:
MessageActionItem?supportCustomPropertiesproperty would only be intended for use as a hack on legacy types, whereas newer types would lean towards using adatafield?