rust: URI type implementation is non-compliant with LSP specification

Our current URI handling uses the rust-url crate, which implements the WHATWG URL spec. However, the Language Server Protocol (LSP) specification explicitly requires URI's to follow RFC 3986.

This causes parsing errors for valid file paths that contain special characters, such as [ or {, which are common in modern frontend frameworks (e.g., Next.js, SvelteKit).

Ref: https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#uri.

lsp-types uses fluent_uri for this reason, with some drawbacks (gluon-lang/lsp-types#284).

Riley Bruins (@ribru17)

Riley Bruins (@ribru17), Umesh Yadav (@imumesh18)

I tried parsing, and this code works fine:

let u = Url::parse("https://aaa.com/[[[").unwrap();
println!("{u:#?}");

Riley Bruins (@ribru17)

Riley Bruins (@ribru17), Umesh Yadav (@imumesh18)

This works fine too:

let u = Url::parse("https://aaa.com/[[[/").unwrap();
let w = u.join("[[[]]]");
println!("{w:#?}");

gluon-lang/lsp-types#261 (comment)

Riley Bruins (@ribru17)

Riley Bruins (@ribru17) It's a bit a different problem, but thanks for sharing. I would consider this crate just message formats, and would normalize urls when passing them to downstream code.

Navigation Menu

Repository navigation

rust: URI type implementation is non-compliant with LSP specification #442

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

rust: URI type implementation is non-compliant with LSP specification #442

Description

Activity

ribru17 commented on Sep 13, 2025

solomatov commented on Oct 27, 2025

solomatov commented on Oct 27, 2025

ribru17 commented on Oct 28, 2025

solomatov commented on Oct 28, 2025

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions