Repository navigation
Exit Code and Signal can be undefined #751
Description
When starting a pty like so:
const terminal = spawn(
command,
(isWindows && options.commandLine) || options.args || [],
options.options || {}
);
terminal.onExit(({ exitCode, signal }) => {
console.log(`terminal:exitCode = ${exitCode}, signal =${signal}`);
and then later doing terminal.kill, I sometimes get terminal:exitCode = undefined, signal =undefined in the log. I belies this should never happen, right?
The problem appears on nodejs 20.18.1 on a windows-2019 github action runner. Locally, it seems to always work.
Activity
Handle exit code undefined
tsmaeder commentedon Jan 1, 2025
Updating the runner image to 2022 fixes the problem. I guess the old image is using winPty. Windows build number is 17763, I believe. (https://github.com/actions/runner-images/blob/main/images/windows/Windows2019-Readme.md)