You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Jun 11, 2026. It is now read-only.
Repository navigation
This repository was archived by the owner on Jun 11, 2026. It is now read-only.
React-Native AsyncStorage -- Deprecated, Moved to React-Native-Community #1053
Worth noting that the PR that references this issue is a step in the right direction, but won't solve the migrations in 0.59 from lean-core as far as I can tell.
import NetInfo from "@react-native-community/netinfo";
This will be a breaking change to consumer of XP.Network, but it should be backwards compatible with previous versions of RN. Users just now will have an extra step of manually linking the native code from @react-native-community/netinfo which will need
If linking is needed, we may want to consider breaking async storage out into its own extension (reactxp-asyncstorage). This way the reactxp core doesn't have any additional native code dependencies (besides react native core)
I don't have a specific timeline in mind. Other than the AsyncStorage change, there haven't been many changes since the last release. Are you in need of this change?
The lean-core items from react-native will generate a series of breaking changes for reactxp as modules are broken out one by one, even if planned carefully, but they can perhaps be batched.
I just wanted to mention that for RN0.60 (which they are about to cut and put on npmjs tagged as @next I think today, WebView and Geolocation modules are completely removed - not just deprecated. I don't think AsyncStorage (this issue) is gone completely yet but if WebView and Geolocation aren't handled in 1.x then without something up tagged as @next for reactxp it will be harder to feel around for where the rough edges are
Activity
luisnaranjo733 commentedon Mar 26, 2019
Worth noting that the PR that references this issue is a step in the right direction, but won't solve the migrations in 0.59 from lean-core as far as I can tell.
I think XP needs to do something like this
And change
to
This will be a breaking change to consumer of XP.Network, but it should be backwards compatible with previous versions of RN. Users just now will have an extra step of manually linking the native code from @react-native-community/netinfo which will need
berickson1 commentedon Apr 2, 2019
If linking is needed, we may want to consider breaking async storage out into its own extension (reactxp-asyncstorage). This way the reactxp core doesn't have any additional native code dependencies (besides react native core)
erictraut commentedon Apr 5, 2019
Yeah, I like that idea. But it would be a major breaking change, probably requiring us to bump the version to reactxp 2.0
linjson commentedon May 20, 2019
Eric Traut (@erictraut) when do you publish reactxp 2.0?
erictraut commentedon May 20, 2019
I don't have a specific timeline in mind. Other than the AsyncStorage change, there haven't been many changes since the last release. Are you in need of this change?
mikehardy commentedon May 21, 2019
The lean-core items from react-native will generate a series of breaking changes for reactxp as modules are broken out one by one, even if planned carefully, but they can perhaps be batched.
I just wanted to mention that for RN0.60 (which they are about to cut and put on npmjs tagged as
@nextI think today, WebView and Geolocation modules are completely removed - not just deprecated. I don't think AsyncStorage (this issue) is gone completely yet but if WebView and Geolocation aren't handled in 1.x then without something up tagged as@nextfor reactxp it will be harder to feel around for where the rough edges are