Skip to content

Formatting with clang-format fails if it takes longer than 10 seconds (i.e. large enough file) #10213

Closed

Description

Use formatting with clang-format with a large file that takes > 10 seconds. Formatting will fail (might only repro on Windows?).

I think we may have added the 10 second timeout to work around a case where clang-format could get permanently stuck. Not sure if we need an adjustable timeout setting or what.

Activity

  1. bigbrett commented on Nov 11, 2024

    @bigbrett

    This is biting me right now as well. Does nobody work on large legacy code bases with long files!?!?. Repro'ed for me on Linux, so not just a Windows issue. Adjustable timeout, or at least a way to disable timeout, would be nice.

  2. sean-mcmanus commented on Nov 11, 2024

    @sean-mcmanus
    ContributorAuthor

    Brett Nicholas (@bigbrett) Thanks for the comment. This issue should've been fixed a long time ago, but I think we just forgot about it.

  3. moved this from Pull Request to Done in cpptoolson Nov 11, 2024
  4. added
    fixedCheck the Milestone for the release in which the fix is or will be available.
    on Nov 11, 2024
  5. sean-mcmanus commented on Dec 6, 2024

    @sean-mcmanus
    ContributorAuthor
  6. locked and limited conversation to collaborators on Mar 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

Projects

  • Status
    Done

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions