Skip to content

koi8ru and koi8t file encodings are not supported on Windows #12272

Closed
Closed
koi8ru and koi8t file encodings are not supported on Windows#12272
Assignees
Colengms
Labels
Language ServicebugfixedCheck the Milestone for the release in which the fix is or will be available.world readyAn issue relating string character encodings, localization translations, etc.
Milestone
1.23.3

Description

@Colengms
Colen Garoutte-Carson (Colengms)
opened on May 1, 2024

VS Code uses iconv for translating file encodings. (Actually https://github.com/microsoft/vscode-iconv-lite-umd ).

Files provided to extensions by VS Code are first converted to UTF-8. But,. for files that cpptools needs to open directly from disk (unopen header files), it needs to deal with encodings directly (i.e. to render doc comments correctly).

Cpptools uses iconv on Linux and Mac, but on Windows it currently uses Win32 APIs. There are 2 encodings explicitly supported by VS Code that are not supported by Win32 APIs:

  • koi8ru - The nearest equivalent is 20866 (koi8-r), but is missing Belarusian.
  • koi8-t - There is no equivalent code page, so no support available on Windows.

This could be addressed by using iconv on Windows as well.

Activity

  1. Colen Garoutte-Carson (Colengms)
    added
    bug
    Language Service
    world readyAn issue relating string character encodings, localization translations, etc.
    on May 1, 2024
  2. Colen Garoutte-Carson (Colengms)
    added this to the Backlog milestone on May 1, 2024
  3. Bob Brown (bobbrow)
    added this to cpptoolson Jun 17, 2024
  4. github-project-automation
    moved this to Triage in cpptoolson Jun 17, 2024
  5. Bob Brown (bobbrow)
    moved this from Triage to No status in cpptoolson Jun 20, 2024
  6. Bob Brown (bobbrow)
    assigned
    Colen Garoutte-Carson (Colengms)
    on Dec 9, 2024
  7. Bob Brown (bobbrow)
    moved this to Todo in cpptoolson Dec 9, 2024
  8. Bob Brown (bobbrow)
    moved this from Todo to In progress in cpptoolson Dec 10, 2024
  9. Colen Garoutte-Carson (Colengms)
    moved this from In progress to Pull Request in cpptoolson Dec 18, 2024
  10. Colen Garoutte-Carson (Colengms)
    added
    fixedCheck the Milestone for the release in which the fix is or will be available.
    on Jan 7, 2025
  11. Colen Garoutte-Carson (Colengms)
    moved this from Pull Request to Done in cpptoolson Jan 7, 2025
  12. Colen Garoutte-Carson (Colengms)
    modified the milestones: Backlog, 1.23.3 on Jan 7, 2025
  13. Sean McManus (sean-mcmanus)
    closed this as completedon Jan 10, 2025

  14. v-frankwang commented on Feb 5, 2025

    @v-frankwang
    v-frankwang
    on Feb 5, 2025

    VS Code Version:1.96.4
    C/C++ Extension Version:1.23.4

    We verified this issue on the latest pre-release and the issue has been fixed!
    Actual results:

    Image

  15. github-actions
    locked and limited conversation to collaborators on Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Language ServicebugfixedCheck the Milestone for the release in which the fix is or will be available.world readyAn issue relating string character encodings, localization translations, etc.

Type

No type

Projects

  • cpptools
    Status
    Done

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions