Skip to content

The cpptools process may deadlock on shutdown if a configuration provider is used #13218

Closed
Bug
Closed
The cpptools process may deadlock on shutdown if a configuration provider is used#13218
Bug
Assignees
Colengms
Labels
Feature: Configuration ProviderRelated to the configurationProvider property, e.g. ms-vscode.cmake-tools, ms-vscode.makefile-tools.Language ServicebugfixedCheck the Milestone for the release in which the fix is or will be available.reliability
Milestone
1.24.0

Description

@sean-mcmanus
Sean McManus (sean-mcmanus)
opened on Jan 30, 2025

It repros with 1.22.11 and 1.23.5 (not sure about 1.21.x and earlier). I'm not sure how common it is.

cpptools_context::request_custom_configuration would be on a thread call stack.

Activity

  1. Sean McManus (sean-mcmanus)
    added
    bug
    Feature: Configuration ProviderRelated to the configurationProvider property, e.g. ms-vscode.cmake-tools, ms-vscode.makefile-tools.
    Language Service
    reliability
    on Jan 30, 2025
  2. Sean McManus (sean-mcmanus)
    added this to the 1.24.0 milestone on Jan 30, 2025
  3. Sean McManus (sean-mcmanus)
    assigned
    Colen Garoutte-Carson (Colengms)
    on Jan 30, 2025
  4. github-project-automation
    added this to cpptoolson Jan 30, 2025
  5. Sean McManus (sean-mcmanus)
    added
    fixedCheck the Milestone for the release in which the fix is or will be available.
    on Jan 31, 2025
  6. Sean McManus (sean-mcmanus)
    moved this to Done in cpptoolson Jan 31, 2025
  7. Sean McManus (sean-mcmanus)
    closed this as completedon Feb 12, 2025

  8. heartacker commented on Feb 12, 2025

    @heartacker
    heartacker
    on Feb 12, 2025
    Contributor

    Sean McManus (@sean-mcmanus) can not find the packaged vsix in github release
    Unfortunately, vscode's plugin store web version does not have an entry point to download either

  9. sean-mcmanus commented on Feb 12, 2025

    @sean-mcmanus
    Sean McManus (sean-mcmanus)
    on Feb 12, 2025
    ContributorAuthor

    heartacker Yeah...I was wondering if there was anyone who wanted the .vsix to published on GitHub for pre-releases. Previously, we only did that for release vsix's (but the marketplace allowed downloads). I'll check if it's okay to start publishing the pre-release .vsix on GitHub (I should know by tomorrow).

  10. sean-mcmanus commented on Feb 12, 2025

    @sean-mcmanus
    Sean McManus (sean-mcmanus)
    on Feb 12, 2025
    ContributorAuthor

    heartacker The release is now updated with the .vsix's: https://github.com/microsoft/vscode-cpptools/releases/tag/v1.24.0

  11. heartacker commented on Feb 12, 2025

    @heartacker
    heartacker
    on Feb 12, 2025
    Contributor

    thank you,my dear bro

  12. github-actions
    locked and limited conversation to collaborators on Mar 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Feature: Configuration ProviderRelated to the configurationProvider property, e.g. ms-vscode.cmake-tools, ms-vscode.makefile-tools.Language ServicebugfixedCheck the Milestone for the release in which the fix is or will be available.reliability

Type

Bug

Projects

  • cpptools
    Status
    Done

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions