IntelliSense-based Go to Definition falls back to the previous implementation if the definition isn't in the same TU #2536

Activity

1. Sean McManus (sean-mcmanus)

   added

   bug

   Language Service

   on Sep 21, 2018
2. Sean McManus (sean-mcmanus)

   added this to the In Progress milestone on Sep 21, 2018
3. Sean McManus (sean-mcmanus)

   self-assigned this

   on Sep 21, 2018
4. Sean McManus (sean-mcmanus)

   modified the milestones: In Progress, October 2018 on Sep 21, 2018
5. Bob Brown (bobbrow)

   added

   Feature Request

   and removed

   bug

   on Oct 3, 2018
6. Sean McManus (sean-mcmanus)

   added

   fixedCheck the Milestone for the release in which the fix is or will be available.Check the Milestone for the release in which the fix is or will be available.

   on Oct 13, 2018
7. sean-mcmanus commented on Oct 15, 2018

   

   Sean McManus (sean-mcmanus)

   on Oct 15, 2018

   Last edited by sean-mcmanus

   ContributorAuthor

   More actions

   This is fixed for the "main" scenarios, but there are subclasses that still don't give correct results, such as

   1. Overloaded methods return all overloads instead of the one that exactly matches the input params (IntelliSense-based Go to Definition returns all overloads instead of just the matching one for overloads not defined in the current TU #2677 ).
   2. I suspect there are probably other buggy scenarios as well (e.g. templates). Let us know if you encounter any...
8. Sean McManus (sean-mcmanus)

   removed their assignment

   on Oct 15, 2018
9. sean-mcmanus commented on Oct 17, 2018

   

   Sean McManus (sean-mcmanus)

   on Oct 17, 2018

   ContributorAuthor

   More actions

   Fixed in https://github.com/Microsoft/vscode-cpptools/releases/tag/0.19.1-insiders2 .
10. Sean McManus (sean-mcmanus)

    closed this as completedon Oct 30, 2018
11. github-actions

    locked and limited conversation to collaborators on Oct 12, 2020