Symbols list: give declarations a different icon than definitions #3117

Activity

1. sean-mcmanus commented on Jan 31, 2019

   

   Sean McManus (sean-mcmanus)

   on Jan 31, 2019

   Last edited by sean-mcmanus

   Contributor

   More actions

   The fix for adding a declaration icon is being tracked by VS Code itself at microsoft/vscode#23927 .

   However, I believe we can move the (declaration) to the front.

   UPDATE: The fix was made, but the check in has been delayed till after the March release ships.
2. Sean McManus (sean-mcmanus)

   self-assigned this

   on Jan 31, 2019
3. Sean McManus (sean-mcmanus)

   added

   Language Service

   Feature Request

   quick fix

   on Jan 31, 2019
4. Sean McManus (sean-mcmanus)

   added this to the February 2019 milestone on Jan 31, 2019
5. JeFrRe commented on Jan 31, 2019

   

   JeFrRe

   on Jan 31, 2019 via email

   Author

   More actions

   OK, thank you. Have a nice day JF

   …

   On Thu, Jan 31, 2019 at 4:13 AM Sean McManus ***@***.***> wrote: The fix for adding a declaration icon is being tracked by VS Code itself at microsoft/vscode#23927 <microsoft/vscode#23927> . However, I believe we can move the (declaration) to the front. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#3117 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/Adl91KU7rua2e4WOMA--aXv-oaHRExJ5ks5vIl9CgaJpZM4aZwAx> .
6. Sean McManus (sean-mcmanus)

   added

   fixedCheck the Milestone for the release in which the fix is or will be available.Check the Milestone for the release in which the fix is or will be available.

   on Feb 6, 2019
7. Sean McManus (sean-mcmanus)

   removed their assignment

   on Feb 6, 2019
8. Sean McManus (sean-mcmanus)

   modified the milestones: March 2019, April 2019 on Mar 12, 2019
9. Sean McManus (sean-mcmanus)

   removed

   fixedCheck the Milestone for the release in which the fix is or will be available.Check the Milestone for the release in which the fix is or will be available.

   on Mar 27, 2019
10. Sean McManus (sean-mcmanus)

    modified the milestones: April 2019, Backlog on Mar 27, 2019
11. sean-mcmanus commented on Mar 27, 2019

    

    Sean McManus (sean-mcmanus)

    on Mar 27, 2019

    Last edited by sean-mcmanus

    Contributor

    More actions

    We decided not to fix this, because:

    1. It causes the declaration and definition to not be sorted next to each other.
    2. We're concerned that non-English speakers might be confused by what "(declaration)" is if it's more visible on the left side.
    3. We were concerned that "(declaration) " was too long to be on the left and shorter things like "(decl)" or some symbol might not be understandable.
    4. You can hover over the symbol to see (declaration)-ness on the right side.

    If more people complain about this then we could reconsiders.

    Or VS Code could fix microsoft/vscode#23927 .

    👎React with 👎2Reacted by Mathieu Moreau and komurugov
12. 9 remaining items

    Load more
13. Bob Brown (bobbrow)

    added this to the 1.2.0 milestone on Oct 20, 2020
14. Elaheh Rashedi (elahehrashedi)

    self-assigned this

    on Nov 30, 2020
15. sean-mcmanus commented on Jan 4, 2021

    

    Sean McManus (sean-mcmanus)

    on Jan 4, 2021

    Contributor

    More actions

    Bob Brown (@bobbrow) VS Code didn't add a declaration enum/tag/icon (just "deprecated"). Should we file a new issue with VS Code or what?
16. Bob Brown (bobbrow)

    modified the milestones: 1.2.0, 1.3.0 on Jan 12, 2021
17. Bob Brown (bobbrow)

    modified the milestones: 1.3.0, On Deck on Feb 2, 2021
18. elahehrashedi commented on Apr 1, 2021

    

    Elaheh Rashedi (elahehrashedi)

    on Apr 1, 2021

    Contributor

    More actions

    follow from here: microsoft/vscode#113845
19. mrx23dot commented on Jan 12, 2024

    

    Mathieu Moreau (mrx23dot)

    on Jan 12, 2024

    More actions

    It's so annoying to see duplicates in C files

    

    If implementation is in the file there is no point showing its prototype,
    but in header it's useful to show the prototype if no implementation.

    tl;dr only show one

    👍React with 👍7Reacted by reichltomas, DinoFive, dmathew-pm, Kerby92, dobrvl2, liaolei and Mathieu Moreau
20. Bob Brown (bobbrow)

    unassigned

    Elaheh Rashedi (elahehrashedi)

    on Jan 3, 2025
21. bobbrow commented on Jan 3, 2025

    

    Bob Brown (bobbrow)

    on Jan 3, 2025

    Contributor

    More actions

    VS Code did not add the feature we needed to implement this. I see that even TypeScript uses (get) and (set) as a modifier for their properties.
22. Bob Brown (bobbrow)

    closed this as not plannedon Jan 3, 2025
23. Bob Brown (bobbrow)

    removed this from the On Deck milestone on Jan 3, 2025
24. mrx23dot commented on Jan 4, 2025

    

    Mathieu Moreau (mrx23dot)

    on Jan 4, 2025

    More actions

    What about only showing one instance (see my comment above) and not changing icon?
25. github-actions

    locked and limited conversation to collaborators on Feb 18, 2025