Skip to content

Leave the non-recognized doxygen commands in comments #5706

Closed

Description

It is possible to leave the commands that are not being converted? We use \note, \pre, and \post. The current behavior is that they don't show up in the tool tip at all.

Originally posted by jhortenstine in #658 (comment)

Activity

  1. sean-mcmanus commented on Jun 26, 2020

    @sean-mcmanus
    ContributorAuthor

    jhortenstine I think the intent is to avoid showing "too much" info, but it seems like only specifically handled commands should be omitted that are deemed to be "too much", instead of omitting all unrecognized commands by default.

    The fact that we don't show \short comments (equivalent to \brief) is an example where were are definitely omitting comments where we should not be (not sure if \note, \pre, and \post fall into that case or not).

    I filed a VS issue at https://developercommunity.visualstudio.com/content/problem/1093392/cc-doxygen-comments-are-not-shown-for-commands-tha.html

  2. jhortenstine commented on Jun 26, 2020

    @jhortenstine

    I am curious on what "too much" info is (not saying it is wrong design). I thought the previous behavior was just to display the entire comment (at least I could not make it drop text).

    Thank you for filing this issue.

  3. sean-mcmanus commented on Jun 26, 2020

    @sean-mcmanus
    ContributorAuthor

    Yes, the previous behavior displayed the entire raw comment formatted as text. I'm not sure which commands would count as "too much" info -- that's just what I was told by the VS VC team when I hit the same issue, but I was using details so I didn't realize the hiding was being applied to all unrecognized commands. Hopefully, they could document what the expected behavior is in regards to which doxygen commands are shown specially, shown as plain text, or not shown.

  4. michelleangela commented on Jun 29, 2020

    @michelleangela
    Contributor

    Just to clarify, the expected behavior for displaying non-Doxygen comments and Doxygen comments in tooltips are different, so I don't think this is a regression for Doxygen support feature.

    Simple text comment (without Doxygen tags/commands) should still display the entire text as there are no text to parse by tags.

    Doxygen comments currently display info in the tooltips from the following tags:

    • brief
    • param
    • return
    • exception
    • deprecated

    Edit: perhaps this is a feature request to display additional Doxygen tags, like add a settings to specify which tags to display.

  5. bobbrow commented on Jun 29, 2020

    @bobbrow
    Contributor

    Does VS Code support collapsible sections in tooltips? If so, we could potentially place the raw comment in there as a stop gap.

  6. jhortenstine commented on Jun 30, 2020

    @jhortenstine

    Michelle Matias (@michelleangela) This is not a feature request to display additional Doxygen tags. This is a request to see all the text from the comment.

    For example:
    /** Initiates a time warp.
    PARAM[in] time Unix time
    Petrus Repo (@pre) Must be going at least 88 mph.
    */
    The current Doxygen pop-up will not show the Petrus Repo (@pre) line at all. I would prefer if the text was there somehow. I am completely fine with it just copying the text.

  7. 11 remaining items

  8. michelleangela commented on Jul 7, 2020

    @michelleangela
    Contributor

    Re-opening until it is released in 0.29.0

  9. sean-mcmanus commented on Jul 9, 2020

    @sean-mcmanus
    ContributorAuthor

    With https://github.com/microsoft/vscode-cpptools/releases/tag/0.29.0-insiders2 you can set the C_Cpp.simplifyStructuredComments setting to false to show all comments. Let us know if you have any additional feedback on that, in particular, the styling changes.

  10. jhortenstine commented on Jul 9, 2020

    @jhortenstine

    The only thing I saw missing was the param's "in", "out", or "in, out".
    The styling was nice. It allows me to find the parameters quickly and helped distinguish between the commands.

    Edit: The in/out is much less important than the fix you have. Thank you for providing a fix.

  11. BillDenton commented on Jul 11, 2020

    @BillDenton

    Sean McManus (@sean-mcmanus) The option shows as "C_Cpp.simplifyStructuredComments" not "C_Cpp.simplyStructuredComments"
    It is a bit intermittent as to when it works or not. I think that may be more general problems with the C/C++ extension as it still (nearly always) consumes a core all the time. Also, I don't have compile json database (waiting for scons to generate it and getting our scons upgraded).
    Like the format, but would have liked to see the "out" and "in,out". We are omitting the "in" for input only parameters.
    I notice if there isn't a description for the parameter then the parameter isn't shown:
    /**

    • Brief description which is shown.
    • PARAM ParamOne Parameter one which is shown.
    • PARAM ParamTwo
      */
      The "brief description" is shown. "ParamOne" shows. "ParamTwo" not shown. If none of the parameters has descriptions then nothing shows. I think all our functions have PARAM (because we check Doxygen during submission), but don't all have descriptions.
  12. bobbrow commented on Jul 13, 2020

    @bobbrow
    Contributor

    The option shows as "C_Cpp.simplifyStructuredComments" not "C_Cpp.simplyStructuredComments"

    I corrected the typo.

  13. michelleangela commented on Jul 13, 2020

    @michelleangela
    Contributor

    Created a feature request on Visual Studio to support '['dir']' of command Doxygen \param so that [in] or [out] are also parsed.
    https://developercommunity.visualstudio.com/content/problem/1111522/support-dir-optional-attribute-of-doxygen-param.html.

    GitHub issue that's tracking request:
    #5773

  14. michelleangela commented on Jul 13, 2020

    @michelleangela
    Contributor

    The fix for this is in progress and will be included in release of 0.29.0.

    I notice if there isn't a description for the parameter then the parameter isn't shown:
    /**

    • Brief description which is shown.
    • PARAM ParamOne Parameter one which is shown.
    • PARAM ParamTwo
      */
      The "brief description" is shown. "ParamOne" shows. "ParamTwo" not shown. If none of the parameters has descriptions then nothing shows. I think all our functions have PARAM (because we check Doxygen during submission), but don't all have descriptions.
  15. sean-mcmanus commented on Jul 16, 2020

    @sean-mcmanus
    ContributorAuthor

    Can this issue be closed (with 0.29.0) or were there additional feedback to follow up on and open new issues for?

  16. michelleangela commented on Jul 16, 2020

    @michelleangela
    Contributor

    This can be closed. I created new issues of the other issues.

  17. locked and limited conversation to collaborators on Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Feature: Doc commentsAn issue related to code comments shown in hover, completion, and signature help.Language ServiceenhancementImprovement to an existing featurefixedCheck the Milestone for the release in which the fix is or will be available.insidersCurrently only repros with our latest Insiders release.

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions