Skip to content

"return cnt;<Enter>" incorrectly completes to "return continue;" #9115

Closed

Description

Caused by #8932 .

We return the "continue;" as completion, but then VS Code never gives us an opportunity to cancel the completion after the ";" is typed. I don't see a good way to work around it, so I'm just going to revert the change.

UPDATE: Reverting the change isn't necessary -- we found another fix.

Activity

  1. Dromantor commented on Mar 31, 2022

    @Dromantor

    Also interferes when defining single letter variables with custom/typedef'd types.

    uint16_t b;<Enter> => uint16_t break;

  2. sean-mcmanus commented on Mar 31, 2022

    @sean-mcmanus
    ContributorAuthor

    Andreas Pareis (@Dromantor) Yes, that is right. Anything that happens to "fuzzy match" the characters in "break" or "continue" and ends with a semicolon.

  3. added
    fixedCheck the Milestone for the release in which the fix is or will be available.
    on Apr 1, 2022
  4. sean-mcmanus commented on May 18, 2022

    @sean-mcmanus
    ContributorAuthor

    Fixed with 1.10.2 (pre-release).

  5. locked and limited conversation to collaborators on Jul 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions