Repository navigation
Adding wrong jar version to the classpath #566
Description
The correct version of the JAR shows up Java Dependencies Pane but when executed a different version is added to the -cp arguments.
Environment
- Operating System: OSX
- JDK version: 1.8.0_201
- Visual Studio Code version: 1.33.1
- Java extension version: 0.42.1
- Java Debugger extension version: 0.17.0
Steps To Reproduce
Sample: https://github.com/dampcake/incubator-druid/tree/fix-eclipse
run mvn install -Pdist -DskipTests to generate dependencies.
Language Server Returning the wrong JAR
Config for project can be found in gist. Either way jetty-util should be 9.4.10 as shown in the dependency view.
Current Result
Wrong JAR dependency version is added to the classpath.
Expected Result
Correct JAR dependency version is added to the classpath.
Additional Informations
This project runs correctly in eclipse so I am not sure where the error is as the dependency view shows the correct JAR.
Activity
yaohaizh commentedon Apr 16, 2019
Jinbo Wang (@testforstephen) Could you help take a look at this issue?
testforstephen commentedon Apr 17, 2019
i can reproduce the issue, should be a bug.
yaohaizh commentedon Apr 18, 2019
Sheng Chen (@jdneo) Is this the same issue that tester fixed?
rcl4444 commentedon May 12, 2019
I also encountered this problem.
rcl4444 commentedon May 12, 2019
in My situation, the Different versions exist simultaneously in the -cp arguments..
testforstephen commentedon Jun 14, 2019
When there are multiple versions for the same dependency existed in the dependency tree, maven will use BFS algorithm to use the nearest version as the target one.
Currently, java-debug used DFS algorithm to determine the dependency, that's the reason why the wrong JAR is added to the classpath. We will take advantage of the same mechanism as what maven did.
testforstephen commentedon Jul 2, 2019
A new release is ready in vscode marketplace. Have a try!
//Adam Peck (@dampcake) rcl4444