The key name in java.test.config should align with the launch configuraiton #852

Activity

1. jdneo commented on Oct 25, 2019

   

   Sheng Chen (jdneo)

   on Oct 25, 2019

   Member

   More actions

   Hi Andrew Strelsky (@astrelsky),

   I'm not quite sure, but I guess you have also set the setting: java.test.defaultConfig. If that is the case, you can just remove that setting or set it to "GhidraTest".

   Please feel free to let me know if this can resolve your problem
2. Sheng Chen (jdneo)

   added

   question

   on Oct 25, 2019
3. astrelsky commented on Oct 25, 2019

   

   Andrew Strelsky (astrelsky)

   on Oct 25, 2019

   Author

   More actions

   Hi Andrew Strelsky (@astrelsky),

   I'm not quite sure, but I guess you have also set the setting: java.test.defaultConfig. If that is the case, you can just remove that setting or set it to "GhidraTest".

   Please feel free to let me know if this can resolve your problem

   I initially had it set to that but removed it and explicitly selected "GhidraTest" as a sanity check. The same results are produced.
4. jdneo commented on Oct 25, 2019

   

   Sheng Chen (jdneo)

   on Oct 25, 2019

   Member

   More actions

   Hmm, I was trying to repro this issue but not able to.

   The implementation is here: https://github.com/microsoft/vscode-java-test/blob/master/src/utils/launchUtils.ts#L58-L60

   The vmargs should be inserted. (Suppose you are using JUnit 4)
5. astrelsky commented on Oct 25, 2019

   

   Andrew Strelsky (astrelsky)

   on Oct 25, 2019

   Author

   More actions

   Hmm, I was trying to repro this issue but not able to.

   The implementation is here: https://github.com/microsoft/vscode-java-test/blob/master/src/utils/launchUtils.ts#L58-L60

   The vmargs should be inserted. (Suppose you are using JUnit 4)
   I'm attaching the full unedited (except for a few privacy snips) output of the java language server and java test runner to this comment.

   If I must I'll attempt to debug the test runner tomorrow. No matter what configuration I make or set I get the same results.

   language_server.log
   test_runner.log

   These are both my global and workspace settings.
   workspace:

   {
       "java.autobuild.enabled": true,
       "java.test.config": {
           "name": "GhidraTest",
           "workingDirectory": "${workspaceFolder}",
           "args": ["-c", "ghidra.GhidraClassLoader"],
           "vmArgs": ["-Djava.system.class.loader=ghidra.GhidraClassLoader", "-Declipse.project.dir=${workspaceFolder}", "-Dpython.console.encoding=UTF-8", "-Dfile.encoding=UTF8", "-Dlog4j.skipJansi=true", "-Duser.country=US", "-Duser.language=en", "-Dsun.stdout.encoding=UTF-8", "-Dsun.err.encoding=UTF-8", "-Dvisualvm.display.name=Ghidra"]
       },
       "java.dependency.packagePresentation": "flat"
   }
   

   global:

   {
       "telemetry.enableTelemetry": false,
       "java.format.settings.url": "${env:GHIDRA_SRC}\\eclipse\\GhidraEclipseFormatter.xml",
       "java.format.settings.profile": "GhidraEclipseFormatter",
       "editor.suggestSelection": "first",
       "vsintellicode.modify.editor.suggestSelection": "automaticallyOverrodeDefaultValue",
       "java.configuration.checkProjectSettingsExclusions": false,
       "java.trace.server": "verbose",
       "terminal.integrated.rendererType": "dom",
       "workbench.startupEditor": "newUntitledFile",
       "java.codeGeneration.useBlocks": true,
       "java.completion.guessMethodArguments": true,
       "java.completion.importOrder": [
           "java",
           "ghidra",
           "javax",
           "com",
           "org"
       ],
       "java.implementationsCodeLens.enabled": true,
       "java.referencesCodeLens.enabled": true,
       "java.errors.incompleteClasspath.severity": "ignore",
       "java.test.report.position": "currentView",
       "python.jediEnabled": false,
       "python.insidersChannel": "off",
       "java.test.report.showAfterExecution": "always",
       "java.test.message.hintForSetingDefaultConfig": false,
       "explorer.confirmDelete": false,
       "java.test.log.level": "verbose",
       "files.associations": {
           "*.jj": "java"
       },
       "editor.tokenColorCustomizations": {
           "[sleigh]": {
               "comments": "#229977"  
           }
       },
       "java.codeGeneration.generateComments": true,
       "java.completion.overwrite": false,
       "java.maven.downloadSources": true,
       "java.debug.logLevel": "verbose"
   }
   
6. jdneo commented on Oct 25, 2019

   

   Sheng Chen (jdneo)

   on Oct 25, 2019

   Last edited by jdneo

   Member

   More actions

   Hi Andrew Strelsky (@astrelsky),

   I guess I found the root cause. It should be vmargs, not vmArgs.

   I need to find out a way to validate the key names in the implementation. Or make it align with the launch configuration. Sorry for the confusion.

   😄React with 😄1Reacted by Andrew Strelsky
7. Sheng Chen (jdneo)

   added

   bug

   and removed

   question

   on Oct 25, 2019
8. Sheng Chen (jdneo)

   changed the title [-]TestRunner ignoring "java.test.config" setting[/-] [+]The key name in `java.test.config` should align with the launch configuraiton[/+] on Oct 25, 2019
9. astrelsky commented on Oct 25, 2019

   

   Andrew Strelsky (astrelsky)

   on Oct 25, 2019

   Author

   More actions

   Hi Andrew Strelsky (@astrelsky),

   I guess I found the root cause. It should be vmargs, not vmArgs.

   I need to find out a way to validate the key names in the implementation. Or make it align with the launch configuration. Sorry for the confusion.

   Yes this was the cause. The good old copypasta strikes again. Thank you for your help. I'll leave this open until the naming situation is resolved.
10. Sheng Chen (jdneo)

    added

    engDebts for engineeringDebts for engineering

    and removed

    bug

    on Oct 15, 2020
11. Sheng Chen (jdneo)

    added this to the 0.25.0 milestone on Oct 15, 2020
12. Sheng Chen (jdneo)

    closed this as completedon Oct 15, 2020