Repository navigation
didChange is being sent before didOpen #1105
Description
This seems to be causing the issue mentioned here: BetterThanTomorrow/calva#1900.
The spec says:
Before a client can change a text document it must claim ownership of its content using the textDocument/didOpen notification.
I do see that the time is the same second, but the didChange appears first so I'm guessing it came a fraction of a second earlier than didOpen.
[Trace - 11:36:32 PM] Sending notification 'textDocument/didChange'.
Params: {
"textDocument": {
"uri": "file:///Users/pez/Projects/tests/minimal-deps/src/foo.clj",
"version": 2
},
"contentChanges": [
{
"text": "(ns foo\n (:require [clojure.string :as string]))\n\n(defn bar\n []\n (let [x 1]\n x))"
}
]
}
[Trace - 11:36:32 PM] Sending notification 'textDocument/didOpen'.
Params: {
"textDocument": {
"uri": "file:///Users/pez/Projects/tests/minimal-deps/src/foo.clj",
"languageId": "clojure",
"version": 1,
"text": ""
}
}
Activity
dbaeumer commentedon Oct 28, 2022
Brandon Ringe (@bpringe) which version are you using? This looks very similar to #968 which for addressed in 8.0.2 (looks like you are using full text document sync as well).
If you are on a version > 8.0.2 can you provide me with steps on how to reproduce this?
bpringe commentedon Oct 29, 2022
We're using 8.0.2.
Steps to reproduce are noted here: BetterThanTomorrow/calva#1900 (comment).
The clojure-lsp server maintainer mentions the ordering issue here: BetterThanTomorrow/calva#1900 (comment).
If you need more details, let me know.
dbaeumer commentedon Oct 31, 2022
I was able to reproduce this (see test case https://github.com/dbaeumer/vscode-lsp-1105). It happens only under the following conditions:
Fixes #1105: didChange is being sent before didOpen
bpringe commentedon Nov 2, 2022
Thanks for the fix!
Fixes microsoft#1105: didChange is being sent before didOpen (microso…