Repository navigation
Overflow value(exceeding uinteger) passed into jsonrpc but still work #1574
Description
The reason is that I found that the fmt feature of my lsp server cannot be used in IntelliJ, but it still work in vscode.
After investigation, I found that I assigned a u32:Max to formatResponse.textedit.range.line in the format's Response
I implemented the lsp server in rust, and u32 was used as the range type in rust's lsp-type, but the range of this value in lsp should be 0-2^31 -1. I think this is the cause of the problem
But I'm not sure whether vscode has special handling for this situation or just forgot to check
Activity
dbaeumer commentedon Oct 18, 2024
VS Code doesn't currently have checking code for this.
rcjsuen commentedon Oct 25, 2024
I ran into this as well. If VS Code detects this what should it do? 🤔
dbaeumer commentedon Oct 28, 2024
The only way how we could handle this is IMO by returning it as a Response error and then report it on the other side via an Error.
dbaeumer commentedon Dec 12, 2024
We should make this a setting since it can have unexpected behaviour.