You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
markupMessageSupport is hard-coded to false, what would it take to enable it? #1860
I want to request functionally to support MarkupContent diagnostic messages with unified-language-server (remark-based markdown linting).
It's messages are authored as markdown at the source, so today things like Don't add a trailing `:` to headings reach the user with the backticks intact.
What should a push-only server read?
The 3.18 guard is textDocument.diagnostic.markupMessageSupport, which is a pull-model
capability and PublishDiagnosticsClientCapabilities has no equivalent.
But asDiagnostic (client/src/common/protocolConverter.ts, ~L329) is shared
between the push and pull paths and switches on the value type rather than the negotiated capability.
Zed hit the same thing in lsp: Add client support for LSP 3.18 markdown diagnostic messages zed-industries/zed#61030 and advertises the capability only when pull
diagnostics are enabled, while handling markup on both paths.
Happy to open a spec issue instead if question 2 belongs upstream.
Yes, that flag is waiting on the support in VS Code.
For push diagnostics we never had client capabilities. I would argue that we should update the spec and say that the property is for both pull and push.
Activity
dbaeumer commentedon Sep 21, 2026
Yes, that flag is waiting on the support in VS Code.
For push diagnostics we never had client capabilities. I would argue that we should update the spec and say that the property is for both pull and push.
Would you be willing to provide a PR?
Marvin-Brouwer commentedon Sep 21, 2026
Or course, I'm happy to help.
Should push-only clients set
textDocument.diagnostic.markupMessageSupport, or would you rather mirror the property underpublishDiagnostics?dbaeumer commentedon Sep 21, 2026
I would actually mirror it. Makes it easier to explain an evolve.
Marvin-Brouwer commentedon Sep 21, 2026
I've given it a go, you can see them here: