JSON-RPC read buffer hangs onto a lot of memory if on big request or response is used. #544

Activity

1. Dirk Bäumer (dbaeumer)

   added

   bugIssue identified by VS Code Team member as probable bugIssue identified by VS Code Team member as probable bug

   on Nov 19, 2019
2. Dirk Bäumer (dbaeumer)

   added this to the 3.16 milestone on Nov 19, 2019
3. alexdima commented on Nov 19, 2019

   

   Alexandru Dima (alexdima)

   on Nov 19, 2019

   Member

   More actions

   There's one more performance aspect to it... If a response has 15MB, and it comes in chunks of 8KB, it means it will come in 1920 chunks. So 1920 times the buffer will be resized and the previous contents copied over.
4. alexdima commented on Nov 19, 2019

   

   Alexandru Dima (alexdima)

   on Nov 19, 2019

   Member

   More actions

   I'd also not feel so bad about it, it is a common issue that has hit even nodejs -- nodejs/node#3145 -- italoacasas/node@cdfa056
5. Dirk Bäumer (dbaeumer)

   added a commit that references this issue on Oct 7, 2020

   Fixes #544: JSON-RPC read buffer hangs onto a lot of memory if on big…

   ...

   This issue will close once commit c446737 is merged into the 'main' branch.

   c446737
6. Dirk Bäumer (dbaeumer)

   closed this as completedin c446737on Oct 8, 2020
7. mjbvz commented on Oct 15, 2020

   

   Matt Bierner (mjbvz)

   on Oct 15, 2020

   More actions

   See c446737 for an example fix
8. Matt Bierner (mjbvz)

   added

   help wantedIssues identified as good community contribution opportunitiesIssues identified as good community contribution opportunities

   on Oct 15, 2020
9. vscodebot

   locked and limited conversation to collaborators on Nov 22, 2020