Repository navigation
Turn off snippets for jedi LSP #15858
Description
Environment data
- VS Code version: 1.55.0
- Extension version (available under the Extensions sidebar): 2021.3.680753044
- OS and version: Ubuntu 20.04 LTS
- Python version: 3.7, deadsnakes
- Type of virtual environment used: virtualenv
- Value of the
python.languageServersetting: JediLSP
Expected behaviour
class Thing: pass
Th<tab> # should complete to:
Thing| # cursor after completed wordActual behaviour
class Thing: pass
Th<tab> # should complete to:
Thing(|) # cursor between completed parensAs far as I can tell this is specific to the JediLSP integration -- changing my language server to Jedi results in the expected completion.
I can maybe see why this is maybe useful if you're planning to construct an instance or calling a function, though there are many other places where callable symbols are used in which you don't want this to happen -- passing them as callbacks and type annotations for example.
Activity
karthiknadig commentedon Apr 6, 2021
Peter Law (@PeterJCLaw) This should be filed on https://github.com/pappasam/jedi-language-server. We don't control this behavior in the extension.
PeterJCLaw commentedon Apr 6, 2021
Ah, thanks, I'd assumed that the insertion text and cursor position was controlled by the extension.
karthiknadig commentedon Apr 6, 2021
Luciana Abud (@luabud) we have snippets on be default in
jediLSP. This seems to be caused by that. Should we turn it off. It is off for the other language server. But we don't have a setting to control this behavior. Need your opinion on should we turn this off by default or provide a setting.[-]JediLSP completions unexpectedly add parentheses[/-][+]Provide a way to turn off snippets from jediLSP[/+]23 remaining items
jpkemp commentedon Apr 21, 2023
GalaxySnail (@GalaxySnail) patch works perfectly, thank you
PeterJCLaw commentedon Apr 21, 2023
Karthik Nadig (@karthiknadig) would you be open to a PR which flipped the default?
feffy380 commentedon Apr 22, 2023
GalaxySnail (@GalaxySnail) perhaps a simpler workaround:
This flips the setting that karthiknadig mentioned.
brettcannon commentedon May 1, 2023
Peter Law (@PeterJCLaw) yep, we would be up for a PR to turn off snippets.
Disable "snippets" expansion in Jedi LSP
Disable "snippets" expansion in Jedi LSP
Disable "snippets" expansion in Jedi LSP
Disable "snippets" expansion in Jedi LSP (#21194)
br3ndonland commentedon May 10, 2023
Thanks Peter Law (@PeterJCLaw) for both reporting and fixing this issue! 👏
Disable "snippets" expansion in Jedi LSP (microsoft#21194)
Merged PR posit-dev/positron-python#122: Merging upstream vscode-pyth…
Merged PR posit-dev/positron-python#122: Merging upstream vscode-pyth…
Autocomplete inherited methods when overriding in child class. Fixes #…