Skip to content

Builds are failing #17666

Closed
#18406
#17757
Closed
Builds are failing#17666
#18406
#17757
Assignees
karrtikr
Labels
area-internalLabel for non-user facing issuesdebtCode quality issuesimportantIssue identified as high-priority

Description

@kimadeline
Kim-Adeline Miguel (kimadeline)
opened on Oct 8, 2021

https://github.com/microsoft/vscode-python/actions/workflows/build.yml?query=branch%3Amain

image

Started happening when VS Code 1.61 was released. Looks like there are terminal activation issues, and one TensorBoard issue.

The TB issue seems to go away if I add torch-tb-profiler ; python_version > '2.7' to the test reqs (#17664), but I have no idea why it's suddenly needed, or why some terminal activation tests are failing.

Activity

  1. Kim-Adeline Miguel (kimadeline)
    added
    needs PR
    debtCode quality issues
    P0
    area-internalLabel for non-user facing issues
    on Oct 8, 2021
  2. github-actions
    added
    triage-neededNeeds assignment to the proper sub-team
    on Oct 8, 2021
  3. Kim-Adeline Miguel (kimadeline)
    removed
    triage-neededNeeds assignment to the proper sub-team
    on Oct 8, 2021
  4. Karthik Nadig (karthiknadig)
    self-assigned this
    on Oct 12, 2021

  5. karthiknadig commented on Oct 14, 2021

    @karthiknadig
    Karthik Nadig (karthiknadig)
    on Oct 14, 2021
    Member

    After investigating by me and Kartik Raj (@karrtikr) we found the issue to be with inspect API from VS Code for the settings. with the latest version of VS Code this API does not retrieve the right value as expected.

  6. karrtikr commented on Oct 14, 2021

    @karrtikr
    Kartik Raj (karrtikr)
    on Oct 14, 2021

    Opened VSCode issue: microsoft/vscode#135121

  7. Karthik Nadig (karthiknadig)
    added 2 commits that reference this issue on Oct 15, 2021

    Skip tests due to microsoft#17666

    0e2bf4f

    Skip tests due to #17666 (#17757)

    c897479
  8. Karthik Nadig (karthiknadig)
    linked a pull request that will close this issueSkip tests due to #17666 #17757on Oct 15, 2021

  9. karthiknadig commented on Oct 15, 2021

    @karthiknadig
    Karthik Nadig (karthiknadig)
    on Oct 15, 2021
    Member

    Revert this commit c897479 after microsoft/vscode#135121 is fixed

  10. Karthik Nadig (karthiknadig)
    removed their assignment
    on Oct 28, 2021
  11. Luciana Abud (luabud)
    added
    importantIssue identified as high-priority
    and removed
    P0
    on Dec 8, 2021
  12. Kartik Raj (karrtikr)
    self-assigned this
    on Feb 1, 2022
  13. Kartik Raj (karrtikr)
    closed this as completedin #18406on Feb 1, 2022
  14. github-actions
    locked as resolved and limited conversation to collaborators on Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

area-internalLabel for non-user facing issuesdebtCode quality issuesimportantIssue identified as high-priority

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions