Skip to content

WIP - Make the language server the default experience #2722

Closed

Description

When VS Code is opened, check for new versions in the background:

  • Check only once a day/week
    • Frequency is user configurable (yes/no)
    • Frequency is Developer configurable (yes/no) (i.e. setting not defined in package.json)
  • Add command to check for latest version
    • This would be visible to everyone
  • Perform check in the background if we already have a language server (previously downloaded)
    • Benefit - User can continue using extension, while network operations are in progress (network comms, download, extract, etc).
  • If a new version is available, then download it and extract it.
    • Finally notify the user about the new version, prompting them to restart.
    • Options in the message – [Restart VS Code] [Do not show this again]
    • This applies to the developer build of the extension
  • If using release version of extension, pin the extension to a specific version of language server (x.y.z).
    • I.e. if we want to release a new version of the language server, we create a new release of the extensino
  • If using dev version of extension, then pin the extension to the first two parts of the language server version.

@Microsoft/pvsc-team /cc

Activity

  1. DonJayamanne commented on Oct 11, 2018

    @DonJayamanne
    Author

    Re-opening as this is a perf issue.
    Brett Cannon (@brettcannon) Why was this closed?

  2. changed the title [-]Improvements to out of band installs of Language Server[/-] [+]Tweaks to choosing what version of the Language Server to install[/+] on Oct 16, 2018
  3. DonJayamanne commented on Oct 16, 2018

    @DonJayamanne
    Author

    Change links to http://pvsc.azureedge.net/python-language-server-beta/Python-Language-Server-osx-x64.0.1.44.nupkg

    Note the CDN Host Name: http://pvsc.azureedge.net/

  4. 4 remaining items

  5. qubitron commented on Jan 3, 2019

    @qubitron

    Don Jayamanne (@DonJayamanne) per the issue title can we add "change default of jedienabled to false"? If not, let me know if another issue tracks this.

  6. DonJayamanne commented on Jan 3, 2019

    @DonJayamanne
    Author

    Not following you, in order to make the language server the default, the way to implement this would be to change the default of JediEnabled to false. I.e. there's no need to track that change, as that's the way to to resolve this issue

  7. DonJayamanne commented on Mar 27, 2019

    @DonJayamanne
    Author

    Prescribed solution:

    • Change default value of jediEnabled to false
  8. changed the title [-]Make the language server the default experience[/-] [+]WIP - Make the language server the default experience[/+] on Apr 15, 2019
  9. locked as resolved and limited conversation to collaborators on May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

feature-requestRequest for new features or functionality

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions